vc4: cec: Restore cec physical address on reconnect #3655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiassofT
reviewed
Jun 3, 2020
drivers/gpu/drm/vc4/vc4_hdmi.c
Outdated
| connected = true; | ||
| if (connected) { | ||
| if (connector->status != connector_status_connected) { | ||
| struct edit *edid = drm_get_edid(connector, vc4_hdmi->ddc); |
There was a problem hiding this comment.
there's a typo here, it should be struct edid (not edit)
Currently we call cec_phys_addr_invalidate on a hotplug deassert. That may be due to a TV power cycling, or an AVR being switched on (and switching edid). This makes CEC unusable. Set it back up again on the hotplug assert. Signed-off-by: Dom Cobley <popcornmix@gmail.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jun 10, 2020
kernel: vc4: cec: Restore cec physical address on reconnect See: raspberrypi/linux#3655 kernel: snd_bcm2835: disable HDMI audio when vc4 is used See: raspberrypi/linux#3640 kernel: Enhanced w1_therm Linux Kernel Module See: raspberrypi/linux#3540 kernel: overlays: Update upstream overlays after vc4-kms-v3d change kernel: overlays: i2c-gpio: Avoid open-drain warnings See: #1381 See: #1401 kernel: staging: vchiq_arm: Use g_dma_dev for dma_unmap_sg See: raspberrypi/linux#3647 firmware: arm_ldconfig: Don't pad initramfs files See: #1395
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jun 10, 2020
kernel: vc4: cec: Restore cec physical address on reconnect See: raspberrypi/linux#3655 kernel: snd_bcm2835: disable HDMI audio when vc4 is used See: raspberrypi/linux#3640 kernel: Enhanced w1_therm Linux Kernel Module See: raspberrypi/linux#3540 kernel: overlays: Update upstream overlays after vc4-kms-v3d change kernel: overlays: i2c-gpio: Avoid open-drain warnings See: raspberrypi/firmware#1381 See: raspberrypi/firmware#1401 kernel: staging: vchiq_arm: Use g_dma_dev for dma_unmap_sg See: raspberrypi/linux#3647 firmware: arm_ldconfig: Don't pad initramfs files See: raspberrypi/firmware#1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we call cec_phys_addr_invalidate on a hotplug deassert.
That may be due to a TV power cycling, or an AVR being switched
on (and switching edid). This makes CEC unusable.
Set it back up again on the hotplug assert.
Signed-off-by: Dom Cobley popcornmix@gmail.com