5.9: ov9281 cherrypick and kms patches #3914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OV9281 appears to drop the clock to LP mode between frames, but the overlay didn't define this at both ends of the CSI2 link. The overlay also had an incorrect link frequency defined, not that the driver ever checked for one. Fix both issues. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
The order of precedence should be: - hotplug GPIO being defined - DDC probe - hotplug register In particular the hotplug register is not valid if a GPIO is defined (eg on Pi0-3), but was being checked. Fixes "943f078 vc4: cec: Restore cec physical address on reconnect" Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
The vc5 HDMI registers hadn't been added into the debugfs register sets, therefore weren't dumped on request. Add them in. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
pelwell
reviewed
Oct 22, 2020
Contributor
Author
|
@popcornmix This HDMI hotplug error may link into your CEC failure on Pi3 as it invalidates settings and generally messes around with CEC state when connected/disconnected. |
Collaborator
|
I'll give it a test. |
Contributor
Author
|
The firmware is overwriting registers? Have we not managed a clean handover from VPU to kernel then? Eek. arm_dt.c masks the VPU away from the interrupts of any DT nodes that start |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 27, 2020
See: raspberrypi/Raspberry-Pi-OS-64bit#4 kernel: ARM: dts: Expand PCIe space on BCM2711 See: raspberrypi/linux#3930 kernel: bcm2711_defconfig: Restore lost downstream char drivers See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=288234&start=100#p1746578 kernel: dt updates, and kms using bcm2711-hvs for dma range See: raspberrypi/linux#3927 kernel: 5.9: ov9281 cherrypick and kms patches See: raspberrypi/linux#3914
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Oct 27, 2020
See: raspberrypi/Raspberry-Pi-OS-64bit#4 kernel: ARM: dts: Expand PCIe space on BCM2711 See: raspberrypi/linux#3930 kernel: bcm2711_defconfig: Restore lost downstream char drivers See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=288234&start=100#p1746578 kernel: dt updates, and kms using bcm2711-hvs for dma range See: raspberrypi/linux#3927 kernel: 5.9: ov9281 cherrypick and kms patches See: raspberrypi/linux#3914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of ff93994 from rpi-5.4.y
One bug fix patch to vc4_hdmi that fixes incorrect hot plug behaviour on Pi3.
One debug patch to dump out all the HDMI registers on PI4 instead of only those that overlap with Pi0-3.