Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay for GalaxyCore GC9A01 displays #5086

Merged

Conversation

juliannojungle
Copy link

This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on spi0 as fb1 framebuffer.

Originally created at https://github.com/juliannojungle/gc9a01-overlay where includes all documentation. Merging in raspberrypi kernel for easy use of said displays on future Raspberry Pi OS releases.

This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
@pelwell
Copy link
Contributor

pelwell commented Jul 11, 2022

Hi @juliannojungle,

I'm not familiar with the GC9A01 display, but the overlay looks like it could work - I'm sure you've been using it enough that we can say it has been tested. I have a few problems with the Pull Request:

  1. I guess you used the GitHub editor to add the overlay source - it uses DOS line endings (each line has a carriage return (0xd/Ctrl-M) as well as a line feed (0xa/Ctrl-J)). This looks ugly using the Git tools.
  2. The "✨" is attention-seeking.
  3. We require a README entry for each overlay - see https://github.com/raspberrypi/linux/blob/rpi-5.15.y/arch/arm/boot/dts/overlays/README. You should be able to copy most of it from a similar overlay such as piscreen. Please preserve the alphabetical ordering, strict indentation (spaces only - no TABs), and two blank lines between entries.
  4. You'll also need to add an entry to the Makefile (https://github.com/raspberrypi/linux/blob/rpi-5.15.y/arch/arm/boot/dts/overlays/Makefile). Again, respect the alphabetical ordering.

@juliannojungle juliannojungle changed the title ✨ Overlay for GalaxyCore GC9A01 displays Overlay for GalaxyCore GC9A01 displays Jul 11, 2022
@juliannojungle
Copy link
Author

Hi, @pelwell!
Yes, I've been using this overlay for quite some time. It works nicely on the display I have.
The "2 - ✨" thing is a commit message pattern adopted by many repositories, based on some rules. The "sparkles" means "introducing new feature". I tottaly missed that I shouldn't be using that here, sorry for that. Already removed.
I'll fix the first topic (carriage return and line feed) and adjust the files from topics 3 and 4 later today.

Thank you very much for the instructions about the merge (I searched the wiki but couldn't find any guidelines).

@juliannojungle
Copy link
Author

Hi, @pelwell. I believe I fixed said problems with the Pull Request now. Thank you for taking time to instruct me on how to proceed.

Overlays which are compatible with all Pis should have the compatible
string `"brcm,bcm2835"`. Delete the others.
@pelwell
Copy link
Contributor

pelwell commented Jul 11, 2022

Nice job. I forgot to mention the compatible string - I prefer to use just brcm,bcm2835 for overlays compatible with all Pis and brcm,bcm2711 for those that only work with Pi 4 - so I've pushed a fix-up patch.

@pelwell pelwell merged commit efaad62 into raspberrypi:rpi-5.15.y Jul 11, 2022
@juliannojungle juliannojungle deleted the juliannojungle/gc9a01-overlay branch July 11, 2022 20:17
pelwell pushed a commit that referenced this pull request Jul 12, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
pelwell pushed a commit that referenced this pull request Jul 12, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jul 13, 2022
See: raspberrypi/linux#5090

kernel: Sound drivers for Dion Audio Kiwi streamer
See: raspberrypi/linux#5092

kernel: Overlay for GalaxyCore GC9A01 displays
See: raspberrypi/linux#5086
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Jul 13, 2022
See: raspberrypi/linux#5090

kernel: Sound drivers for Dion Audio Kiwi streamer
See: raspberrypi/linux#5092

kernel: Overlay for GalaxyCore GC9A01 displays
See: raspberrypi/linux#5086
popcornmix pushed a commit that referenced this pull request Jul 18, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Jul 18, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Aug 1, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Aug 1, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Aug 1, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
herrnst pushed a commit to herrnst/linux-raspberrypi that referenced this pull request Aug 7, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Aug 15, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Aug 15, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
popcornmix pushed a commit that referenced this pull request Aug 23, 2022
This includes an overlay for easy use of displays based on GalaxyCore's GC9A01 single chip driver, attaching them on `spi0` as `fb1` framebuffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants