Skip to content

Conversation

@waveshare
Copy link

The content of PR
1.support waveshare 4inch DSI LCD (C)
2.Resolved waveshare 11.9inch touch orientation error

@6by9
Copy link
Contributor

6by9 commented Mar 7, 2024

Generally fine, but a few comments.

Kernel coding style is to use tabs set to 8 spaces.

Does the 11.9" panel not need touchscreen-size-x and touchscreen-size-y set?

The 4_0_inch_C override needs documenting in README.

Please keep dtoverlay changes in separate commits from driver changes. This allows patches to be squashed together more easily.

@waveshare
Copy link
Author

Generally fine, but a few comments.

Kernel coding style is to use tabs set to 8 spaces.

Does the 11.9" panel not need touchscreen-size-x and touchscreen-size-y set?

The 4_0_inch_C override needs documenting in README.

Please keep dtoverlay changes in separate commits from driver changes. This allows patches to be squashed together more easily.

The GT chip driver will automatically obtain the touch information of the touch chip, then report the maximum value, minimum value of the touch, and the current touch coordinates to the input subsystem, and complete the input mapping.
If the touchscreen-size content in the dts file is not set, it will not affect the touch effect;

@waveshare waveshare force-pushed the 4inch-DSI-LCD-C branch 2 times, most recently from 594d620 to 8042b28 Compare March 8, 2024 09:52
@pelwell
Copy link
Contributor

pelwell commented Mar 8, 2024

The automated checks have spotted that your new parameter (4_0_inch_C) is not documented.
I've spotted that its name doesn't match an existing parameter (7_0_inchC). Try to be consistent.

Eng33 added 3 commits March 8, 2024 18:36
Signed-off-by: Eng33 <eng33@waveshare.net>
Signed-off-by: Eng33 <eng33@waveshare.net>
Signed-off-by: Eng33 <eng33@waveshare.net>
@waveshare
Copy link
Author

The automated checks have spotted that your new parameter (4_0_inch_C) is not documented. I've spotted that its name doesn't match an existing parameter (7_0_inchC). Try to be consistent.

ok,changed 4_0_inch_C to 4_0_inchC

@6by9
Copy link
Contributor

6by9 commented Mar 8, 2024

The GT chip driver will automatically obtain the touch information of the touch chip, then report the maximum value, minimum value of the touch, and the current touch coordinates to the input subsystem, and complete the input mapping. If the touchscreen-size content in the dts file is not set, it will not affect the touch effect;

Great, I just wasn't aware of that so it looked odd.

@pelwell
Copy link
Contributor

pelwell commented Mar 8, 2024

So we're just lacking a README entry for the new parameter...

Signed-off-by: Eng33 <eng33@waveshare.net>
@waveshare
Copy link
Author

So we're just lacking a README entry for the new parameter...

OK,added parameter 4_0_inchC to README

@pelwell pelwell merged commit 8db8a2b into raspberrypi:rpi-6.1.y Mar 11, 2024
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Mar 12, 2024
See: raspberrypi/linux#6028

kernel: Add specific clk-producer/-consumer overlays for Hifiberry DACplus
See: raspberrypi/linux#6024

kernel: Imx296 updates
See: raspberrypi/linux#6027

kernel: support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error
See: raspberrypi/linux#6017

kernel: ASoC: dwc: Correct channel count reporting
See: raspberrypi/linux#6023

kernel: ARM: dts: bcm2712-rpi: Add i2c<n>_pins labels
See: raspberrypi/linux#6005

kernel: Panel updates
See: raspberrypi/linux#6019

kernel: Backport pwm-ir-tx precision improvements
See: raspberrypi/linux#6018
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Mar 12, 2024
See: raspberrypi/linux#6028

kernel: Add specific clk-producer/-consumer overlays for Hifiberry DACplus
See: raspberrypi/linux#6024

kernel: Imx296 updates
See: raspberrypi/linux#6027

kernel: support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error
See: raspberrypi/linux#6017

kernel: ASoC: dwc: Correct channel count reporting
See: raspberrypi/linux#6023

kernel: ARM: dts: bcm2712-rpi: Add i2c<n>_pins labels
See: raspberrypi/linux#6005

kernel: Panel updates
See: raspberrypi/linux#6019

kernel: Backport pwm-ir-tx precision improvements
See: raspberrypi/linux#6018
@Darmur
Copy link

Darmur commented Mar 14, 2024

I tried this patch and the touch of the 11.9" display works fine on a RPi5, but it's 1cm off on the vertical axes if the display is connected to a RPi4 or a CM4 with a Waveshare Carrier Board

@waveshare could you please check?

@waveshare waveshare deleted the 4inch-DSI-LCD-C branch November 29, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants