-
Notifications
You must be signed in to change notification settings - Fork 5.3k
support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error #6017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Generally fine, but a few comments. Kernel coding style is to use tabs set to 8 spaces. Does the 11.9" panel not need touchscreen-size-x and touchscreen-size-y set? The Please keep dtoverlay changes in separate commits from driver changes. This allows patches to be squashed together more easily. |
782f749 to
911872a
Compare
The GT chip driver will automatically obtain the touch information of the touch chip, then report the maximum value, minimum value of the touch, and the current touch coordinates to the input subsystem, and complete the input mapping. |
594d620 to
8042b28
Compare
|
The automated checks have spotted that your new parameter ( |
Signed-off-by: Eng33 <eng33@waveshare.net>
Signed-off-by: Eng33 <eng33@waveshare.net>
Signed-off-by: Eng33 <eng33@waveshare.net>
8042b28 to
f0f8616
Compare
ok,changed |
Great, I just wasn't aware of that so it looked odd. |
|
So we're just lacking a README entry for the new parameter... |
Signed-off-by: Eng33 <eng33@waveshare.net>
OK,added parameter |
See: raspberrypi/linux#6028 kernel: Add specific clk-producer/-consumer overlays for Hifiberry DACplus See: raspberrypi/linux#6024 kernel: Imx296 updates See: raspberrypi/linux#6027 kernel: support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error See: raspberrypi/linux#6017 kernel: ASoC: dwc: Correct channel count reporting See: raspberrypi/linux#6023 kernel: ARM: dts: bcm2712-rpi: Add i2c<n>_pins labels See: raspberrypi/linux#6005 kernel: Panel updates See: raspberrypi/linux#6019 kernel: Backport pwm-ir-tx precision improvements See: raspberrypi/linux#6018
See: raspberrypi/linux#6028 kernel: Add specific clk-producer/-consumer overlays for Hifiberry DACplus See: raspberrypi/linux#6024 kernel: Imx296 updates See: raspberrypi/linux#6027 kernel: support_4inch_DSI_LCD_C-Resolved_11.9inch_touch_orientation_error See: raspberrypi/linux#6017 kernel: ASoC: dwc: Correct channel count reporting See: raspberrypi/linux#6023 kernel: ARM: dts: bcm2712-rpi: Add i2c<n>_pins labels See: raspberrypi/linux#6005 kernel: Panel updates See: raspberrypi/linux#6019 kernel: Backport pwm-ir-tx precision improvements See: raspberrypi/linux#6018
|
I tried this patch and the touch of the 11.9" display works fine on a RPi5, but it's 1cm off on the vertical axes if the display is connected to a RPi4 or a CM4 with a Waveshare Carrier Board @waveshare could you please check? |
The content of PR
1.support waveshare 4inch DSI LCD (C)
2.Resolved waveshare 11.9inch touch orientation error