Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add driver for rpi-proto #908

Merged
merged 1 commit into from
Mar 25, 2015
Merged

Add driver for rpi-proto #908

merged 1 commit into from
Mar 25, 2015

Conversation

wbx-github
Copy link
Contributor

Forward port of 3.10.x driver from https://github.com/koalo
We are using a custom board and would like to use rpi 3.18.x
kernel. Patch works fine for our embedded system.

URL to the audio chip:
http://www.mikroe.com/add-on-boards/audio-voice/audio-codec-proto/

Playback tested with and without devicetree enabled.

@popcornmix
Copy link
Collaborator

ping @pelwell

@pelwell
Copy link
Contributor

pelwell commented Mar 24, 2015

Since enabling device tree support in all RPi kernels, we no longer accept patches to bcm2708.c (and bcm2709.c, which you have omitted) for the sole purpose of creating platform devices.

So:

  1. Remove the bcm2708.c patches.
  2. Include patches for bcmrpi_defconfig and bcm2709_defconfig that set SND_BCM2708_SOC_RPI_PROTO=m. The right way to do this is to patch a configuration and then use "ARCH=arm make savedefconfig", then diff them against the original configurations to make sure the changes look sensible.
  3. Is RPI_PROTO really what you want to call it?

@wbx-github
Copy link
Contributor Author

Hi,

I am really to stupid for github. Do I need to refork and apply the changed patch to add a new pull request?
RPI_PROTO looks okay for me, better then two different names like in the original driver code.

Will fix it tomorrow.

@pelwell
Copy link
Contributor

pelwell commented Mar 24, 2015

I think you can squash your commits then git push --force .

@pelwell
Copy link
Contributor

pelwell commented Mar 24, 2015

Aside from that, it looks good.

Add driver for rpi-proto
c2f2a82 
Forward port of 3.10.x driver from https://github.com/koalo
We are using a custom board and would like to use rpi 3.18.x
kernel. Patch works fine for our embedded system.

URL to the audio chip:
http://www.mikroe.com/add-on-boards/audio-voice/audio-codec-proto/

Playback tested with devicetree enabled.

Signed-off-by: Waldemar Brodkorb <wbrodkorb@conet.de>
@wbx-github
Copy link
Contributor Author

Thanks for review and the force push tipp. Didn't know that.

@pelwell
Copy link
Contributor

pelwell commented Mar 25, 2015

The overlay looks good, the code builds cleanly and although I can't test it, the driver looks plausible.

@popcornmix OK to merge?

popcornmix added a commit that referenced this pull request Mar 25, 2015
@popcornmix
Merge pull request #908 from wbx-github/rpi-3.18.y
266bd9d 
Add driver for rpi-proto
@popcornmix popcornmix merged commit 266bd9d into raspberrypi:rpi-3.18.y Mar 25, 2015
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Mar 25, 2015
@popcornmix
kernel: Bump to 3.18.10
cd355a9 
kernel: Add driver for rpi-proto
See: raspberrypi/linux#908

kernel: Fix reduced volume issue for users of PCM5122 DAC
See: raspberrypi/linux#889

firmware: arm_loader: Refactor freq/freq_min logic and allow h264 freq_min to be increased

firmware: arm_loader: Allow non-turbo voltage to be increased by up to two config steps

firmware: video codec: refactor userdata release mechanics in categoriser

firmware: hvs: experimental: reduce hvs non-panic priority on 2836

firmware: arm_loader: Add force_eeprom_read setting

firmware: bootcode: Add bootcode_delay for an early delay
See: #401

firmware: dispmanx: Fix stereoscopic flags to invert left/right eyes with multichannel
See: http://forum.kodi.tv/showthread.php?tid=211501&pid=1956924#pid1956924

firmware: [deinterlace] Avoid asserts on half rate deinterlace

firmware: [audioplus] Limit samplerate/channels to something we expect to be able to support through hdmi

firmware: [deinterlace] Fall back to fast algorithm in a cleaner way

firmware: MMAL opaque - reduce back below 128 btyes
See: #377 (comment)

firmware: arm_loader: Avoid double-free when disabling HAT overlay, and always relocate overlay phandles

firmware: vc_pool_image: add locking around linked image release
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Mar 25, 2015
@popcornmix
kernel: Bump to 3.18.10
8751db9 
kernel: Add driver for rpi-proto
See: raspberrypi/linux#908

kernel: Fix reduced volume issue for users of PCM5122 DAC
See: raspberrypi/linux#889

firmware: arm_loader: Refactor freq/freq_min logic and allow h264 freq_min to be increased

firmware: arm_loader: Allow non-turbo voltage to be increased by up to two config steps

firmware: video codec: refactor userdata release mechanics in categoriser

firmware: hvs: experimental: reduce hvs non-panic priority on 2836

firmware: arm_loader: Add force_eeprom_read setting

firmware: bootcode: Add bootcode_delay for an early delay
See: raspberrypi/firmware#401

firmware: dispmanx: Fix stereoscopic flags to invert left/right eyes with multichannel
See: http://forum.kodi.tv/showthread.php?tid=211501&pid=1956924#pid1956924

firmware: [deinterlace] Avoid asserts on half rate deinterlace

firmware: [audioplus] Limit samplerate/channels to something we expect to be able to support through hdmi

firmware: [deinterlace] Fall back to fast algorithm in a cleaner way

firmware: MMAL opaque - reduce back below 128 btyes
See: raspberrypi/firmware#377 (comment)

firmware: arm_loader: Avoid double-free when disabling HAT overlay, and always relocate overlay phandles

firmware: vc_pool_image: add locking around linked image release
@pelwell pelwell mentioned this pull request Apr 2, 2015
Closed
@mypiandrew mypiandrew mentioned this pull request Sep 11, 2016
Closed
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this pull request Feb 27, 2017
@popcornmix
kernel: Bump to 3.18.10
eb62c94 
kernel: Add driver for rpi-proto
See: raspberrypi/linux#908

kernel: Fix reduced volume issue for users of PCM5122 DAC
See: raspberrypi/linux#889

firmware: arm_loader: Refactor freq/freq_min logic and allow h264 freq_min to be increased

firmware: arm_loader: Allow non-turbo voltage to be increased by up to two config steps

firmware: video codec: refactor userdata release mechanics in categoriser

firmware: hvs: experimental: reduce hvs non-panic priority on 2836

firmware: arm_loader: Add force_eeprom_read setting

firmware: bootcode: Add bootcode_delay for an early delay
See: raspberrypi#401

firmware: dispmanx: Fix stereoscopic flags to invert left/right eyes with multichannel
See: http://forum.kodi.tv/showthread.php?tid=211501&pid=1956924#pid1956924

firmware: [deinterlace] Avoid asserts on half rate deinterlace

firmware: [audioplus] Limit samplerate/channels to something we expect to be able to support through hdmi

firmware: [deinterlace] Fall back to fast algorithm in a cleaner way

firmware: MMAL opaque - reduce back below 128 btyes
See: raspberrypi#377 (comment)

firmware: arm_loader: Avoid double-free when disabling HAT overlay, and always relocate overlay phandles

firmware: vc_pool_image: add locking around linked image release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbx-github @popcornmix @pelwell