From bfb0dbc452e211580e137a5efeb1eccef8b86ac4 Mon Sep 17 00:00:00 2001 From: Jasper van der Neut Date: Tue, 18 Jan 2022 14:55:19 +0100 Subject: [PATCH 1/2] Enable internal pullup on B-pin. --- pio/quadrature_encoder/quadrature_encoder.pio | 1 + 1 file changed, 1 insertion(+) diff --git a/pio/quadrature_encoder/quadrature_encoder.pio b/pio/quadrature_encoder/quadrature_encoder.pio index b2a0b82f2..63d5c36f8 100644 --- a/pio/quadrature_encoder/quadrature_encoder.pio +++ b/pio/quadrature_encoder/quadrature_encoder.pio @@ -114,6 +114,7 @@ static inline void quadrature_encoder_program_init(PIO pio, uint sm, uint offset pio_sm_set_consecutive_pindirs(pio, sm, pin, 2, false); pio_gpio_init(pio, pin); gpio_pull_up(pin); + gpio_pull_up(pin + 1); pio_sm_config c = quadrature_encoder_program_get_default_config(offset); sm_config_set_in_pins(&c, pin); // for WAIT, IN From 39934159fd75775b168f61a6059d06d71fec7574 Mon Sep 17 00:00:00 2001 From: Jasper van der Neut Date: Tue, 18 Jan 2022 14:56:19 +0100 Subject: [PATCH 2/2] pio_gpio_init is not needed for input pins. --- pio/quadrature_encoder/quadrature_encoder.pio | 1 - 1 file changed, 1 deletion(-) diff --git a/pio/quadrature_encoder/quadrature_encoder.pio b/pio/quadrature_encoder/quadrature_encoder.pio index 63d5c36f8..d245d4b69 100644 --- a/pio/quadrature_encoder/quadrature_encoder.pio +++ b/pio/quadrature_encoder/quadrature_encoder.pio @@ -112,7 +112,6 @@ increment_cont: static inline void quadrature_encoder_program_init(PIO pio, uint sm, uint offset, uint pin, int max_step_rate) { pio_sm_set_consecutive_pindirs(pio, sm, pin, 2, false); - pio_gpio_init(pio, pin); gpio_pull_up(pin); gpio_pull_up(pin + 1);