Add some extra defines to customise behaviour of STDIO_USB_RESET modes #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
requested changes
Mar 4, 2021
src/rp2_common/pico_bootsel_via_double_reset/pico_bootsel_via_double_reset.c
Outdated
Show resolved
Hide resolved
kilograham
approved these changes
Mar 5, 2021
kilograham
approved these changes
Mar 5, 2021
Contributor
kilograham
left a comment
kilograham
left a comment
There was a problem hiding this comment.
I would have added a static inline function for getting the pin mask, but not reason enough to change at this second
kilograham
pushed a commit
that referenced
this pull request
Mar 5, 2021
#226) * Add some extra defines to customise behaviour of STDIO_USB_RESET modes * Tweaks to STDIO_USB_RESET defines
kilograham
pushed a commit
that referenced
this pull request
Mar 5, 2021
#226) * Add some extra defines to customise behaviour of STDIO_USB_RESET modes * Tweaks to STDIO_USB_RESET defines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've got this right, but you'll obviously want to review it quite carefully @kilograham
I've tested the defines in combination with VIA_BAUD_RATE and they all work fine, but I've been unable to test with VIA_VENDOR_INTERFACE.