Skip to content

Commit

Permalink
Fix build with glibc 2.22
Browse files Browse the repository at this point in the history
  • Loading branch information
@asavah
asavah committed Aug 22, 2015
1 parent b864a84 commit 34f0207
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion containers/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ add_definitions(-DDL_PATH_PREFIX="${VMCS_PLUGIN_DIR}/")

SET( GCC_COMPILER_FLAGS -Wall -g -O2 -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wcast-qual -Wwrite-strings -Wundef )
SET( GCC_COMPILER_FLAGS ${GCC_COMPILER_FLAGS} -Wextra )#-Wno-missing-field-initializers )
SET( GCC_COMPILER_FLAGS ${GCC_COMPILER_FLAGS} -std=c99 -D_POSIX_C_SOURCE=199309L )
SET( GCC_COMPILER_FLAGS ${GCC_COMPILER_FLAGS} -std=c99 -D_POSIX_C_SOURCE=200112L )
SET( GCC_COMPILER_FLAGS ${GCC_COMPILER_FLAGS} -Wno-missing-field-initializers )
SET( GCC_COMPILER_FLAGS ${GCC_COMPILER_FLAGS} -Wno-unused-value )

Expand Down

3 comments on commit 34f0207

@kraj
Copy link
Contributor

@kraj kraj commented on 34f0207 Aug 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had posted a pull request with same patch like 15 days ago. At least a mention of that would have been good. See
#251

@asavah
Copy link
Contributor Author

@asavah asavah commented on 34f0207 Aug 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I did not see you patch and as you can see in comments 3b9ac3e mthuurne the author of the original commit is who has the credits, I only tested it and submitted the PR.
  2. Your PR is big and touches other things, wayland has nothing to do with POSIX macros.
    Guess you still have to learn about how the big projects prefer to work with git - touch one thing at a time and squash commits.
  3. It's up to the mantainer to decide what is merged and what is not.

@kraj
Copy link
Contributor

@kraj kraj commented on 34f0207 Aug 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not care for credits. but a note in pull request would have notified this pull request. on two, I guess I did not pay attention that github keeps updating the pull request underneath automatically when branch was rebased. It will work better if I had created pu branches. Which I will do for rest of it.

Please sign in to comment.