Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed text_extents width bug. #192
Merged
Conversation
popcornmix
added a commit
that referenced
this pull request
Aug 5, 2014
Fixed text_extents width bug.
|
Thanks much; let me know if you want me to try to cut the unused args. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chinasaur commentedAug 3, 2014
Sorry; I left a bug in here last time around. Width was having start_x
subtracted from it inappropriately. Fixed.
As it turns out, it appears that start_x and start_y are irrelevant parameters
to this function. I didn't remove them though as they're in vgft.h and it's not
clear whether external clients are allowed access to this interface. I marked
them as unused.