New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled mapscii init #58

Merged
merged 2 commits into from Nov 19, 2018

Conversation

1 participant
@jaller94
Collaborator

jaller94 commented Nov 19, 2018

Mapscii.init() returns a Promise. All Promises have to be handled.

In this case it should be safe to just print the error. I did not add process.exit(1); because the executing of console commands can be async and interrupted by a process being force quit.

@jaller94 jaller94 merged commit cf47316 into master Nov 19, 2018

@jaller94 jaller94 deleted the unhandled-mapscii-init branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment