feat: block border merging - #1874
Merged
Merged
Conversation
Only added on the first one of the +1/-1 to avoid redundancy
refactor : more compact early return Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
orhun
reviewed
Jun 3, 2025
orhun
reviewed
Jun 3, 2025
This was skipping the first / last cell of a border when there was no adjacent line that would make a corner
j-g00da
commented
Jun 4, 2025
Co-authored-by: Jagoda Estera Ślązak <128227338+j-g00da@users.noreply.github.com>
orhun
added a commit
that referenced
this pull request
Jun 4, 2025
When two borders overlap, they will automatically merge into a single,
clean border instead of overlapping.
This improves visual clarity and reduces rendering glitches around corners.
For example:
```
assert_eq!(Cell::new("┘").merge_symbol("┏", MergeStrategy::Exact).symbol(), "╆");
```
Co-authored-by: pauladam94 <poladam2002@gmail.com>
Co-authored-by: Paul Adam <65903440+pauladam94@users.noreply.github.com>
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Co-authored-by: Orhun Parmaksız <orhun@archlinux.org>
Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
Member
|
Updated commit message was force pushed in 671c2b4 |
Member
|
Thanks @pauladam94 for kicking this off, and @j-g00da for jumping on it and doing a bunch of work to get it over the line. |
takumi-earth
pushed a commit
to earthlings-dev/ratatui
that referenced
this pull request
Jan 27, 2026
When two borders overlap, they will automatically merge into a single,
clean border instead of overlapping.
This improves visual clarity and reduces rendering glitches around corners.
For example:
```
assert_eq!(Cell::new("┘").merge_symbol("┏", MergeStrategy::Exact).symbol(), "╆");
```
Co-authored-by: pauladam94 <poladam2002@gmail.com>
Co-authored-by: Paul Adam <65903440+pauladam94@users.noreply.github.com>
Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Co-authored-by: Orhun Parmaksız <orhun@archlinux.org>
Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored by @pauladam94
Fork of #1729