Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 5 #766

Open
wants to merge 1 commit into
base: master
from
Open

Allow Symfony 5 #766

wants to merge 1 commit into from

Conversation

@simPod
Copy link

simPod commented Nov 22, 2019

No description provided.

@simPod simPod force-pushed the simPod:allow-symfony-5 branch from 890c24e to b19d2aa Nov 22, 2019
@cboden

This comment has been minimized.

Copy link
Member

cboden commented Nov 30, 2019

I haven't kept up with Symfony 5 release documentation. Are there no API changes/breaks?

@Nek-

This comment has been minimized.

Copy link

Nek- commented Nov 30, 2019

Symfony is supposed to break indeed. But it looks like it doesn't impact ratchet.

I tested this patch:

git remote add simpod git@github.com:simPod/Ratchet.git
git fetch simpod
git checkout allow-symfony-5
composer install

With the following wstest config in fuzzingclient.json:

{
   "outdir": "./reports/servers",
   "servers": [
      {
         "url": "ws://127.0.0.1:8000"
      }
   ],
   "cases": ["*"],
   "exclude-cases": [],
   "exclude-agent-cases": {}
}
php tests/autobahn/bin/fuzzingserver.php &
wstest -m fuzzingclient

Everything is green. (artifacts zipped joined)
reports.zip

@simPod

This comment has been minimized.

Copy link
Author

simPod commented Nov 30, 2019

I also run in against static analysis and everything seems to be compatible

@WyriHaximus

This comment has been minimized.

Copy link

WyriHaximus commented Dec 2, 2019

Considering it looks like it's covered by the tests I doubt there will be issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.