itemInfo parsing #110
Merged
itemInfo parsing #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Config 'ShowItemDesc' in application.php defaults to false. Change to true in order to use. * New SQL file `cp_itemdesc` in the charDB schema. * Tested with itemInfo.lua from https://github.com/zackdreaver/ROenglishRE/ but assuming the format is the same, it should work with files sourced from other locations. * Regex could possibly do with sharpening up a little. * Remember to ensure that your PHP post_max_size is large enough to accomodate your file. * Not the best implementation, but it works. * Todays regex headache is thanks to @hurtsky for the suggestion. Signed-off-by: Akkarinage <akkarin@rathena.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp_itemdescin the charDB schema.Signed-off-by: Akkarinage akkarin@rathena.org