Permalink
5 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Implemented Wolfchev's Laboratory instance. (credits: Hercules 1a477c4)
Signed-off-by: Euphy <euphy.raliel@rathena.org>
- Loading branch information
Showing
with
3,193 additions
and 581 deletions.
- +1 −1 db/re/instance_db.txt
- +1 −1 db/re/item_db.txt
- +1 −2 db/re/mob_db.txt
- +3,185 −0 npc/re/instances/WolfchevLaboratory.txt
- +2 −574 npc/re/quests/quests_lighthalzen.txt
- +1 −0 npc/re/scripts_athena.conf
- +1 −1 sql-files/item_db_re.sql
- +1 −2 sql-files/mob_db_re.sql
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
dd9719dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change the 1.0 comment to your own name...? Add your own line...
dd9719dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be
1.0 Initial Release [Kisuka]
1.1 "something" [Euphy]
dd9719dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is how it's supposed to be. That's how it's always been.
dd9719dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there'd be no "1.0", if anyone tries searching for the file in git history.
You're listed as the author in the "By:" line and your commit is in my commit log.
dd9719dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also no "1.0" releases of majority of the scripts and source in rAthena, since you guys are a fork of eAthena. Your argument doesn't make any sense. Please readd the original changelog to the script. You pulled this file from another project. You are modifying an existing script, add a new line to the changelog. You don't have the right to just remove the previous history because your adding it here for the first time. That goes against the spirit of open source development. The file has it's own history outside of this project, you can't overwrite that.