Permalink
5 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Rebalancing of 1st/2nd/Transcendent class skills (#4072)
* Fixes #3715. * kRO changelog: http://ro.gnjoy.com/news/notice/View.asp?seq=7040 * Refactored size_fix database to YAML. Thanks to @flamefury for his translations! Thanks to @Angelic234, @mrjnumber1, @Badarosk0, @OptimusM, @attackjom, @Playtester, Melvo, @cydh, @cahya1992, Sigma, @whupdo, @teededung, @ecdarreola, @hotspicy945, @RagnaWay, @sader1992 for bug testing!
- Loading branch information
Showing
with
1,910 additions
and 941 deletions.
- +1 −1 conf/battle/client.conf
- +0 −7 db/import-tmpl/size_fix.txt
- +33 −0 db/import-tmpl/size_fix.yml
- +38 −0 db/pre-re/size_fix.yml
- +37 −0 db/re/size_fix.yml
- +504 −709 db/re/skill_db.yml
- +5 −0 db/re/skill_nocast_db.txt
- +8 −4 db/re/skill_tree.txt
- +0 −11 db/size_fix.txt
- +89 −0 db/size_fix.yml
- +202 −60 src/map/battle.cpp
- +55 −14 src/map/clif.cpp
- +1 −0 src/map/map-server.vcxproj
- +5 −0 src/map/mob.cpp
- +28 −6 src/map/pc.cpp
- +1 −1 src/map/pc.hpp
- +2 −0 src/map/script_constants.hpp
- +353 −64 src/map/skill.cpp
- +18 −0 src/map/skill.hpp
- +498 −63 src/map/status.cpp
- +20 −0 src/map/status.hpp
- +12 −1 src/map/unit.cpp
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,33 @@ | ||
| # This file is a part of rAthena. | ||
| # Copyright(C) 2019 rAthena Development Team | ||
| # https://rathena.org - https://github.com/rathena | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation, either version 3 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ########################################################################### | ||
| # Size Fix Database | ||
| ########################################################################### | ||
| # | ||
| # Size Fix Settings | ||
| # | ||
| ########################################################################### | ||
| # - Weapon Weapon type. | ||
| # Small Small size modifier. (Default: 100) | ||
| # Medium Medium size modifier. (Default: 100) | ||
| # Large Large size modifier. (Default: 100) | ||
| ########################################################################### | ||
|
|
||
| Header: | ||
| Type: SIZE_FIX_DB | ||
| Version: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,38 @@ | ||
| # This file is a part of rAthena. | ||
| # Copyright(C) 2019 rAthena Development Team | ||
| # https://rathena.org - https://github.com/rathena | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation, either version 3 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ########################################################################### | ||
| # Size Fix Database | ||
| ########################################################################### | ||
| # | ||
| # Size Fix Settings | ||
| # | ||
| ########################################################################### | ||
| # - Weapon Weapon type. | ||
| # Small Small size modifier. (Default: 100) | ||
| # Medium Medium size modifier. (Default: 100) | ||
| # Large Large size modifier. (Default: 100) | ||
| ########################################################################### | ||
|
|
||
| Header: | ||
| Type: SIZE_FIX_DB | ||
| Version: 1 | ||
|
|
||
| Body: | ||
| - Weapon: Knuckle | ||
| Medium: 75 | ||
| Large: 50 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,37 @@ | ||
| # This file is a part of rAthena. | ||
| # Copyright(C) 2019 rAthena Development Team | ||
| # https://rathena.org - https://github.com/rathena | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation, either version 3 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ########################################################################### | ||
| # Size Fix Database | ||
| ########################################################################### | ||
| # | ||
| # Size Fix Settings | ||
| # | ||
| ########################################################################### | ||
| # - Weapon Weapon type. | ||
| # Small Small size modifier. (Default: 100) | ||
| # Medium Medium size modifier. (Default: 100) | ||
| # Large Large size modifier. (Default: 100) | ||
| ########################################################################### | ||
|
|
||
| Header: | ||
| Type: SIZE_FIX_DB | ||
| Version: 1 | ||
|
|
||
| Body: | ||
| - Weapon: Knuckle | ||
| Large: 75 |
Oops, something went wrong.
ea8da71There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the loading/reloading time for the skill_db.yml normal? i am thinking its kinda slow like its the same loading time as mapcache
ea8da71There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yaml-cpp will task more time in debug mode, trying the RELEASE mode?
ea8da71There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which line is responsible for removing the sonic blow movement? I didn't find
ea8da71There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8d2c26d
ea8da71There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which line is the one that made changes for dancer/bard songs ? i'd like to change it back to old effect