Trap visibility

[MrAntares]

Git Version: 12628 - 2014-12-04 05:04:30 (luciar)
Client Date: 2012-04-10
Src Mods: NONE
General settings:

• Full Renewal
• 1/1/1/1/1 rate
• PK server (not in towns, above lvl 30)
• PVP ATK/Skill modifers: 100%
• WOE ATK/Skill modifers: rA default
• Official walk path and stacking
• Exp and drop penalty table values below 100% set to 100%
• Party and attacker exp bonus: +40%
• More at (Hungarian, use translate): http://wiki.ragna.ro/

How to reproduce: Use a trap skill
Description:

Hunter laying traps can't see it's own traps, neither can allies see.

[MrAntares]

Same issue with reverbation

[Playtester]

Hmmm, I can see traps on my 20130708 client.

I know there are special clients for PVP servers were all traps are invisible, hmmm.

Are certain conditions required for them to be invisible?

[MrAntares]

They should be invisible only if you didn't see the dude laying em. Idk about the rules, but my point is I can't see my own ones, which kills the trappin for some players.
Eg.: http://youtu.be/ZzRQsoxUDjY
I made this for the reverbation bug, but you can (or can't) see this one as well.

[aleos89]

Are you sure your client files are all good? When I was testing Reverberation last night (on 20130807) I could see it just fine. I didn't test trap skills but since you said you couldn't see Reverberation as well.

[MrAntares]

I have been using this client (2012-04-10) for 2 years now, didn't change anything, except I updated the server. Traps were always visible, until after one update they vanished, so it's not my client, unless the packets were altered/broken for this client.

(I'm not using 2013 client for numerous reasons. First of all I can't get it to work. No matter what guide I follow they just won't. Second, I don't like the 3rd party launchers. I could get used to them, but since the client simply won't start I just gave up. If you can give me a FULL client (data, lua, dlls, raw exe) and a decent diff tool, I can try to make a 2013 client and re-test the issues, but until I see only a bunch of stupid links and I have to figure out every stupid combination of them, I'm just done with client making.)

[Playtester]

I'm not sure about the other devs but the only things I changed in terms of skill unit display was:

1. Fixed the bug that a trap wasn't removed from the screen when it was knocked out of visible range so it left a "dead trap sprite" forever. b88e953
2. Fixed the bug that if a unit group gets completely moved (usually happens with Dances/Songs when Dancer/Bard moves) it stayed on the screen instead of disappearing. 76a30f3

Can you identify at which commit it stopped working?

Most likely it's one of the commits that affected clif.c, you can see the list here: https://github.com/rathena/rathena/commits/master/src/map/clif.c

[MrAntares]

I haven't played with hunter/bard class in the last half-one year and I did the updates 2-3 months intervals, so it's hopeless for me to find when it went wrong. The only question is: Is there anyone with 2012-04-10 client who has the same issue? If none of the same client users have this issue, then it's invalid, and I'll simply light up my server and piss on it.

I have other issues with my client such as random crashes on teleport, and when granny3d monsters appear, so it is possible that only my client is crap. But since I was unable to get the community in the past years to make a launch-ready client downloadable in ONE ZIP**, I'll just wait for a miracle.

**Means you click on a link and you have a client which only needs a clientinfo.xml conf, and it's ready. No crappy hex-haxing, no half-bugged diff-haxing, no lua hunting for the latest non-korean version which is probably from the stone age but it's the only, no lua/lub converting, no figuring out which dir goes in which, no incompatible versions, no days of googling to find info or missing files because the ones in the posted links are outdated/broken/missing, no crappy haxing tools which crash upon every 10th mouse movement, and no 1000 X 10^623 versions of which I have to find the least bugged.

Sorry for the rage, but I'm so fed up with the client side. If there's a reason, this is it for which I might quit RO.

[Playtester]

I suck at client stuff too, so I can't really help with that. I'm already happy I can connect to my test server and I needed help from 3 staff members to just accomplish that. XD'

It's not that hopeless, just set up a test server, slowly roll back from commit to commit and test again if you can see the traps or not.

Once forums are back up you could also ask around if someone else uses the 2012 client.

It could also be a "compiled with wrong PACKETVER set" issue.

[MrAntares]

Only a suspicion, but this seems to be it:
05d3c6b#diff-c01c74464349b4b305a8b20a5f885bac

Again, Dec. 01 version, 2012-04-10 client, renewal, no src mods.

[cydh]

testing all clients, 2010-07-30, 2012-04-10, 2012-04-18, 2013-08-07, 2013-12-23, everything is good.

so, don't say u put 1 to traps_setting https://github.com/rathena/rathena/blob/master/conf/battle/skill.conf#L122-L125

[Playtester]

Hmm if that's supposed to replicate official PVP server behavior, then traps should at least be visible to the one placing the trap.

[MrAntares]

And anyone who sees it. The strange thing is that I can see traps nowhere. Towns fields, pvp, gvg, nowhere...
@cydh I have traps_setting 1, but description says "Who came into view of it", so those seeing the trap being laid should see the trap until they move out of range, especially the one who lays the traps. We can't even detect laid traps, nor target them in any way. It was working with this config for 7 years now, except the last few moths, but okay, I'll change this if this is not the official setting...

[MrAntares]

Okay, it is working with trap_setting 0, traps and reverbations are now visible.
Still, I consider trap_setting 1 to be broken, since people should see their own traps and those as well who see the dude laying the traps.

Since trap_setting 1 is not default, feel free to close this report or fix it. Your choice.
On my part, I'm done. Thanks for the infos and help :)

[Playtester]

On the Aegis test server (which is based on a PVP leak) you can only see your own traps. Other player can never see traps even if they were on-screen when they were placed.

But in any case, now that we know it depends on that option it should be easier to fix. :-)

Edit: Also in non-PVP servers, the trap invisibility actually exists for PVP maps as far as I know.

Edti2: Also I think the way it is coded won't make Detect work either.