Re-opening: Unloadnpc does not allow re-loading of NPC

[raynra]

For example:
@loadnpc npc/custom/resetnpc.txt
@unloadnpc Reset Girl
@loadnpc npc/custom/resetnpc.txt <-- will not work second time

This was broken back in August due to:
402170c

This was supposed to fix it:
https://rathena.org/board/tracker/issue-9311-loadnpcfile-bug/?gopid=28440#entry28440

[cydh]

why don't just remove that @unloadnpc? haha.

personally I never use that command nowadays, I prefer @unloadnpcfile. Just because when @unloadnpc it unload a NPC doesn't care the file path, so when use @loadnpc it will loads all NPCs in same file, there's NPC duplication possibilities.

[raynra]

Ah, thanks for clarifying that up, Cydh. Perhaps @unloadnpc should be depreciated in favor of @unloadnpcfile then?

[chriser-]

i added @reloadnpc a long time ago on my server, and i think it would be a good idea to implement it on rathena. all it does is just @unloadnpcfile and @loadnpc (copy&pasta)
and i have never ever used @unloadnpc because i think its totally not needed (especially when you can rightclick > kill, which basically does the same)

[Emistry]

I believe @unloadnpcfile wouldnt remove any permanent monster spawn script.
when using the custom made @reloadnpc as stated by @chriser- , I think it would make the case worst by keep repeating the permanent monster spawn, end up the map flood with the monsters if the user keep use @reloadnpc without aware there are permanent monster script there.
Depend on the script, sometime you might not want the script to trigger other OnInit label from other npc within the same file, @unloadnpc + @loadnpc would still the best option.

rightclick > kill , doesnt alway work. I mean under certain circumstance it is not available depend on client diff I think.

** but I like the idea for using @reloadnpc too xD

[marky291]

I created my own reload - @refreshfile

I took both @unloadnpcfile and @loadnpc commands from source code and combined it into the one command. Which runs both unloadnpcfile first and load npcs automatically. Saves huge amount of time when testing an NPC and need it to refresh.

[chriser-]

thats exactly what i wrote xD

[marky291]

I see, nice to know others have the same idea. This should be added, don't know why not.

Also @unloadnpc is very handy when you have a set of npcs in one file but need to emergency kill one due to exploit or bug, not that it happens often but nice option to have.

[anacondaq]

@refreshnpc will be awesome command for different purposes on the fly.

[raynra]

Is anyone else experiencing @unloadnpcfile sometimes failing after a reload of a script?
For example, just right now, I did:

@unloadnpcfile npc/custom/warper.txt
@loadnpc npc/custom/warper.txt
@unloadnpcfile npc/custom/warper.txt
File not found.
@unloadnpcfile failed.

It seems like when it fails, it never works again.

[cydh]

@raynra hmm never
I used those commands repeatedly when test a NPC without restart server.

[cydh]

err yea, somehow confirmed for CentOS. for @loadnpc -> @unloadnpcfile, the failed to @loadnpc again.
can anyone test this? https://gist.github.com/cydh/99f991dce97f6e975424

[brianluau]

When @loadnpc fails because the file is already loaded, the current message is:
261: Script could not be loaded.

Suggestion - change the message to something like "File is already loaded." or "Script is already loaded."

[rubie123]

This issue still exists. my current revision is: 0d8a7c0
I tried to find if you guys already had a fix for this and found this topic. So is there a fix?

[anacondaq]

confirm

[rubie123]

Hope this will be fixed soon...

[Everade]

confirmed

Ruining my day since > 1 Year

[Everade]

It's still driving me crazy.
Would be great if this could be avoided:

The only workaround that exists is to increase the slash count.
It has not been fixed.