Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soul Link for Bard/Dancer doesn't enable the linked skill #4801

Closed
ihernandeza opened this issue Apr 15, 2020 · 31 comments · Fixed by #5055
Closed

Soul Link for Bard/Dancer doesn't enable the linked skill #4801

ihernandeza opened this issue Apr 15, 2020 · 31 comments · Fixed by #5055

Comments

@ihernandeza
Copy link

@ihernandeza ihernandeza commented Apr 15, 2020

  • Client Date: 20150513
  • Server Mode: Pre_renewal
  • Description of Issue:
    • Result: Can't use bonus skills
      image

    • Expected Result: Allow to use linked skills, based on Mastered ones as Dancer explained here

    • How to Reproduce:

  • Master any of this skills as a dancer: Humming, Dont Forget Me, Fortune Kiss, Service for you

  • Trow Bard and Dancer spirit skill to the Dancer using a Soul Linker on Doble Login

  • Check the "Other Tab" on the skill window of the dancer, Bard skills will appear grayed.

  • If you have some skill points, and change the window mode to the small one, you could add some points to every skill, but if you press the "Reset" button, your skill points will be restored but not the skill level, causing an infinite skill level up (Fortunally, this is only visual)
    image

  • Modifications that may affect results:
    none
@BotGigo
Copy link

@BotGigo BotGigo commented Apr 15, 2020

Same at 20180620 client.
also pre-renewal

@pigati23
Copy link
Contributor

@pigati23 pigati23 commented Apr 15, 2020

I just tried it and it works perfectly. I think your problem is on the client side.
I just tried it on Dancer and Gypsy.
123

@reunite-ro
Copy link
Contributor

@reunite-ro reunite-ro commented Apr 15, 2020

Yeah I wanna said the same think as pigati23 stated.
Since limitation of Level in Client Side = in lub files.

Try to check your skilldescript.lub, skillinfolist.lub, skilltreeview.lub and skilltreeview_web.lub

@BotGigo
Copy link

@BotGigo BotGigo commented Apr 15, 2020

@pigati23 Can you leve me your skillinfoz folder? cus im trying with many diferent folders and its not working. if its possible :D

@BotGigo
Copy link

@BotGigo BotGigo commented Apr 15, 2020

@reunite-ro Actually i have been reading those files and i didnt find anything.

@pigati23
Copy link
Contributor

@pigati23 pigati23 commented Apr 15, 2020

@reunite-ro
Copy link
Contributor

@reunite-ro reunite-ro commented Apr 15, 2020

Btw chriss only translates Renewal, maybe You can use zackdreaver for Pre-Renewal (as I read the issues related pre-re) but he didnt update the files for it since last year.

@pigati23
Copy link
Contributor

@pigati23 pigati23 commented Apr 15, 2020

Btw chriss only translates Renewal, maybe You can use zackdreaver for Pre-Renewal (as I read the issues related pre-re) but he didnt update the files for it since last year.

I haven't reviewed it in detail, but I think that may work for what he is needing. If you find many differences, you can correct it with Zack's translation for pre-renewal.

@BotGigo
Copy link

@BotGigo BotGigo commented Apr 15, 2020

Already try those two, ill try Chirs :D

@victorrod
Copy link

@victorrod victorrod commented Apr 15, 2020

same here, the problem it's only with gypsy, clown it's ok
https://rathena.org/board/topic/122697-gypsy-skill-three-etc3rd-tab-still-disabled-after-soul-linked-help/

@aleos89
Copy link
Contributor

@aleos89 aleos89 commented Apr 19, 2020

image
I'm unable to reproduce this issue as well on the current master (dd9b6d3). Make sure your client data is accurate.

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented May 9, 2020

I see its already reported 25 days ago. @ihernandeza i assume you are testing it in your live server? Because the local ones doesnt have this problem(assumingly your local is running windows OS).

In windows VPS i confirm its working as intended.
in Linux based OS i confirm its not working.

@ihernandeza
Copy link
Author

@ihernandeza ihernandeza commented May 9, 2020

live server at google compute engine, centos 7

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented May 9, 2020

@ihernandeza i knew it. Lets wait for the fix. As you can see i reported as well. Concluded that it has something to do with linux based OS.

#4909

@Kreustoo
Copy link
Contributor

@Kreustoo Kreustoo commented May 17, 2020

Same problem here, linux based live server: grayed
Local windows server using the same lub: not grayed

But using gepard on live and not a local? Anyone else?

@Akaineko-astasi
Copy link
Contributor

@Akaineko-astasi Akaineko-astasi commented May 18, 2020

Did you try with an actual Soul Linker character, not self buff?

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented May 18, 2020

@Akaineko-astasi yes. It really doesnt work. Like i said for you to reproduce this. You have to have live server. As ive mentioned here #4909

@Kreustoo My local server have gepard. And it works. My live has gepard as well but it doesnt work.

@Kreustoo
Copy link
Contributor

@Kreustoo Kreustoo commented May 18, 2020

Yeah both time I tried with a real SL character using the spell.

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented May 18, 2020

As for me. ive tried everything. Even updating my compiler in my vps. #4909

@Stingor
Copy link

@Stingor Stingor commented May 23, 2020

having same issue here, but actually if you put clown card (armor) you normaly get poem of bragi in you skills, so its not client side i guess ?

@BotGigo
Copy link

@BotGigo BotGigo commented May 24, 2020

having same issue here, but actually if you put clown card (armor) you normaly get poem of bragi in you skills, so its not client side i guess ?

yeah, aparently it is a problem in the OS

In windows VPS i confirm its working as intended.
in Linux based OS i confirm its not working.

@sinju92
Copy link

@sinju92 sinju92 commented Jun 1, 2020

Im get same issue but only for gypsy.
for Clown everything its okay
my rathena version
https://github.com/rathena/rathena/commit/157392cd1a3174abf2051907126aba4617f8ffbc

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented Jun 3, 2020

any news from this?

@aleos89
Copy link
Contributor

@aleos89 aleos89 commented Jun 5, 2020

What version of gcc are you all using?

@ihernandeza
Copy link
Author

@ihernandeza ihernandeza commented Jun 5, 2020

What version of gcc are you all using?

7

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented Jun 5, 2020

Yes me too 7. As per my vps provider. Is there a way to check the current version?

@aleos89
Copy link
Contributor

@aleos89 aleos89 commented Jun 5, 2020

$ gcc --version
$ g++ --version

These should return the versions.

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented Jun 5, 2020

here ya go.
image

The only way to fix this issue is to use SECRET's diff regarding soul linker. However. That diff will give you memory leaks.

@Stingor
Copy link

@Stingor Stingor commented Jun 5, 2020

gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
g++ (Debian 6.3.0-18+deb9u1) 6.3.0 20170516

@aleos89
Copy link
Contributor

@aleos89 aleos89 commented Jun 5, 2020

Are you referring to this diff?

@gidzdlcrz
Copy link

@gidzdlcrz gidzdlcrz commented Jun 5, 2020

Yes @aleos89. That is the solution for this problem. I never want to use it in the first place but it was forced me to because of this bug. Anyhow its a good feature indeed. The only concern is it does give me and everybody else memory leak.

aleos89 added a commit that referenced this issue Jun 6, 2020
* Fixes #4801.
* Fixes Bard and Dancer not gaining the opposite class's skills.
* Cleans up check to not be reliant on sketchy index checks.
Thanks to @ihernandeza, @gidzdlcrz, and @Lemongrass3110!
@aleos89 aleos89 closed this in #5055 Jun 7, 2020
aleos89 added a commit that referenced this issue Jun 7, 2020
* Fixes #4801.
* Fixes Bard and Dancer not gaining the opposite class's skills.
* Cleans up check to not be reliant on sketchy index checks.
Thanks to @ihernandeza, @gidzdlcrz, and @Lemongrass3110!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.