Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skills do not disappear from the skill bar when removing weapons. #5382

Open
respect1428 opened this issue Sep 6, 2020 · 5 comments · May be fixed by #5931
Open

Skills do not disappear from the skill bar when removing weapons. #5382

respect1428 opened this issue Sep 6, 2020 · 5 comments · May be fixed by #5931
Labels
component:core mode:prerenewal mode:renewal priority:low status:confirmed type:bug

Comments

@respect1428
Copy link

@respect1428 respect1428 commented Sep 6, 2020 •
edited

  • rAthena Hash:
  • Client Date:
    2020-03-04
  • Server Mode:
    Renewal

  • Description of Issue:

    • Result:
      After I removed the card, but my skills remained. But can't use skills
      Picture of Issue >> https://imgur.com/a/sNFrr7W

    • Expected Result:
      I want the skill to disappear after removing the equipment.

    • How to Reproduce:

    • Official Information:

  • Modifications that may affect results:

Alt Text
@respect1428 respect1428 closed this Sep 6, 2020
@respect1428 respect1428 reopened this Sep 6, 2020
@respect1428
Copy link
Author

@respect1428 respect1428 commented Sep 6, 2020

351f0db Not work

@aleos89
Copy link
Contributor

@aleos89 aleos89 commented Sep 9, 2020

I believe this is official behavior last I tested on kRO.

@attackjom
Copy link
Contributor

@attackjom attackjom commented Sep 9, 2020

It refresh after change equipment

  1. Equip accessory -> Prontera Map [Creamy card] -> get Teleport and Increase Agi
    image

  2. Switch to other acc
    image

  3. Wireshark show it send 0x441 packet (clif_deleteskill)
    image

@alisonrag
Copy link

@alisonrag alisonrag commented Sep 11, 2020

Should be some recent update. last time i tested in bRO skill was not disappearing from skillbar.

@Lemongrass3110 Lemongrass3110 mentioned this issue Jan 25, 2021
Closed
@aleos89 aleos89 mentioned this issue May 7, 2021
Closed
@JinYuichi
Copy link

@JinYuichi JinYuichi commented May 10, 2021 •
edited

Has anyone found a solution for this stuck skill ? I am very annoying when you are using stalker also the skills that you copy and change are stuck... you don't know which skill is the one that you really have copied.
Exe: 2020-03-04 RE
sd123w

aleos89 added a commit that referenced this issue May 10, 2021
@aleos89
Fixes temp skills not clearing from skill tree
c3f1ff9 
* Fixes #5382.
* Fixes temporary skills not removing themselves from the skill tree when switching equipment.
Thanks to @attackjom!
@aleos89 aleos89 linked a pull request May 10, 2021 that will close this issue
Open
@aleos89 aleos89 mentioned this issue Jul 30, 2021
Closed
@aleos89 aleos89 mentioned this issue Aug 11, 2021
Closed
Lemongrass3110 added a commit that referenced this issue Jan 17, 2022
@Lemongrass3110
Fixed newer clients not removing skills
81bd250 
Fixes #5382

Thanks to @Balferian for his help with the research.

Thanks to @respect1428 for reporting it.
@Lemongrass3110 Lemongrass3110 mentioned this issue Jan 17, 2022
Open
poipioil added a commit to poipioil/rathena that referenced this issue Jan 25, 2022
@poipioil
Squashed commit of the following:
a168b2a 
commit 6a57a6c
Author: Lemongrass3110 <lemongrass@kstp.at>
Date:   Mon Jan 17 23:25:04 2022 +0100

    Removing a brainfart - thx LGTM

commit 81bd250
Author: Lemongrass3110 <lemongrass@kstp.at>
Date:   Mon Jan 17 22:50:15 2022 +0100

    Fixed newer clients not removing skills

    Fixes rathena#5382

    Thanks to @Balferian for his help with the research.

    Thanks to @respect1428 for reporting it.
@Lemongrass3110 Lemongrass3110 mentioned this issue Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core mode:prerenewal mode:renewal priority:low status:confirmed type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes temp skills not clearing from skill tree rathena/rathena
5 participants
@aleos89 @alisonrag @attackjom @respect1428 @JinYuichi