Cleaned and merged the chat functions #1277
Conversation
This adresses the issue that clients from late 2015 will not zero terminate most of their messages anymore. It should also fix the problem with the unknown packets that were most likely caused by adding the zero termination directly into the packet buffer.
|
@admkakaroto @Darkelfen @Badarosk0 this could be interessting for you to test, because of #1049. |
|
I will put in the emulator and see if there is a difference, if it improves, or something. |
|
is this related to random "disconnected from server" via chat ? |
|
It most likely is. Since I was not able to reproduce these issues myself I can not promise, but it is most likely related to the wrong handling of the zero termination. |
|
my players have reported if they chat too much, they get sudden "disconnected from server" >< |
|
Yes . This is happening in client 2015+ |
|
Any estimate on this? my players disconnect so fast.. just by talking in party chat using 2015-11-04aRagexe.exe on the latest rAthena git. |
|
Test it and give us feedback then it will be merged into master faster. |
|
I'm with personal problems, so I'm away from ragnarok for some time ... I can only re-test and help within two weeks. |
Conflicts: src/map/clif.c
Lemongrass3110
force-pushed
the
cleanup/chat_messages
branch
from
595540b
to
a3470e8
Compare
This adresses the issue that clients from late 2015 will not zero terminate most of their messages anymore.
It should also fix the problem with the unknown packets that were most likely caused by adding the zero termination directly into the packet buffer.