Initial Release of Equipment Switch #3548

Lemongrass3110 · 2018-10-04T20:32:04Z

Addressed Issue(s): cant find the correct one - if someone does please link it.

Server Mode: renewal

Description of Pull Request:
First implementation of the new kRO feature.

Thanks to everyone who contributed to this release in any way, be it donations, information or testing.

Since our PACKETVER is not supporting it this is required for CI

anacondaq · 2018-10-04T21:42:30Z

Okay, founded problem (I think people will report about it with a time)

It's because of MAX_STORAGE > 850, while almost all uses 900-1000 slots for storage. I think these people will report about the issue. I don't think it's possible somewhat to do with it instead of decreasing max storage size a little bit.

Lemongrass3110 · 2018-10-04T21:50:44Z

@Anacondaqq yeah totally forgot about this, since it has been this long already. I think the new maximum was somewhere between 820~850 items.

Atemo · 2018-10-04T22:16:15Z

conf/battle/feature.conf

@@ -67,6 +67,10 @@ feature.roulette: on
 // Requires: 2015-05-13aRagexe or later
 feature.achievement: on

+// Equipment Switch (Note 1)
+// Requires: 2017-02-08bRagexeRE or later
+feature.equipswitch: off


The feature is not available on official server by default?

I think this is because of the warning that’s presented at start up since our packetver is 2015~ and it’s causing the build bots to “fail”.

Balferian · 2018-10-05T13:48:20Z

Solved - Thanks to @aleos89
When server starts I have some SQL errors with cart_inventory.
All work fine, but need to update upgrade_20181004.sql
add column to cart_inventory:favorite and equipSwitch.
Do we need column "favorite" in cart_inventory? Oo

aleos89 · 2018-10-05T17:40:08Z

Sounds like you applied the diff wrong. Cart Inventory doesn't have a favorite tab so that column is not needed in SQL. Look at the diff again and make sure it only applies to TABLE_INVENTORY when parsing char-server side.

MathReaper · 2018-10-07T06:25:44Z

My client stop "updating the receive packet" after trying to equip something.

I've received the packet: 9A 0A 02 00 02 00 00 00 00 00 98 0A 0F 00 22 00 00 00 00 00 (size 20)

0x0A9A and 0x0A98 aren't different packets? The client understand that are two packets in only one recv buffer? Interesting.

I can't understand why my client "stops" when I receive the packet 0x0a98, lol.
The only thing that happens is that I receive an error message saying: Unable to register item. Wth?

Client date: 20170215

MathReaper · 2018-10-07T06:56:37Z

src/map/clif_packetdb.hpp

+#if PACKETVER >= 20170208
+	parseable_packet(0x0A97,8,clif_parse_equipswitch_add,2,4);
+	packet(0x0A98,10);
+	parseable_packet(0x0A99,4,clif_parse_equipswitch_remove,2,4);


Trying to unequip boots:
[Warning] clif_parse: Received unsupported packet (packet 0x0040, 4 bytes received), disconnecting session #3.

0x0A99 have size 8 on client 20170215.

Sorry I do not have that client to confirm this. :(

I can upload here. I will open a repo of clients unpacked by myself soon.
2017-02-15aRagexeRE - MediaFire

This has been fixed as well. :)

BruSantato · 2018-10-07T11:18:07Z

I added the correct Diff all in a clean rAthena, when connecting the emulator does not have any error, but it is not changing the equipments when clicking on CHANGE
I use a client: 20180530

anacondaq · 2018-10-07T12:05:23Z

@BruSantato check feature.conf feature.equip_switch must be on, by default it's off.

BruSantato · 2018-10-07T12:15:08Z

@Anacondaqq Sorry, I forgot to mention this, it's already activated, and even then it does not make the exchange of equipment

MathReaper · 2018-10-08T01:17:03Z

2H weapons actually conflicts with 1H weapons or shields (switching 2H weapon for weapon + shield) and the 1H weapon is removed from equipment switch interface.

MathReaper · 2018-10-11T02:58:46Z

@BruSantato I'm just reporting an issue, this isn't related to what you're reporting. xD

# Conflicts: # src/map/clif.cpp # src/map/clif.hpp

ghost · 2018-10-14T08:26:07Z

Not sure if this is intended but if you try to change equip from 2Handed Equipement with Normal Weapon + Shield it fails. (In-game no error thought and in console)

HTR: Equip 2H Sword -> Set shield and knife to replacement window -> Use the feature still the same.

See image attached.

MathReaper · 2018-10-14T15:51:24Z

@ecdarreola I think that this happens because pc_equipswitch function is called two times by the skill because the equipment is in another position too, and the weapon is switched 2 times?

@aleos89

Thanks to @aleos89

@aleos89

Found by @aleos89

lukasrmattos · 2018-10-30T17:04:59Z

Test:

I have the problem that after changing one time the last items are not more change able without drag this again. Is this the default behavior?

https://vimeo.com/297988385

BrOgBr · 2018-10-30T17:23:32Z

@zellkennedy I think that this problem was already reported, it's because the two-handed weapons. ;)

lukasrmattos · 2018-10-30T22:53:54Z

@zellkennedy I think that this problem was already reported, it's because the two-handed weapons. ;)

Hmm, @Lemongrass3110 sayed that was fixed but still, I can reproduce it and ecdarreola problem is other.

mjonrest · 2018-11-03T07:50:21Z

i found this error.. this is cause by monster that spamming waterball like drake,high wizard katrinn,strouf,etc

BruSantato · 2018-11-18T13:52:18Z

Hello, I just applied the system in a clean rathena, the items are added to the replace slots but I can not change the items, the system is active in features.conf and the sql table is imported
I'm using a client 2018-06-20 and the system does not work

RadianFord · 2018-12-03T08:12:47Z

I've tested this one and the only problem was.

1. Place main gauche in the replacement equipment.
2. Equip infiltrator in the normal equipment window.
3. Switch/Change equipment's.
4. Result: dagger switched perfectly.
5. Switch it again into the infiltrator weapon.
6. Result: Dagger will go back to normal state.

Mateuus · 2018-12-07T23:59:25Z

For those who are in trouble not working with 2018-06-20
Comment this part

clif.cpp:

/*
	if( DIFF_TICK(tick, sd->equipswitch_tick) < 0 ) {
	// Client will not let you send a request
		return;
	}
 	sd->equipswitch_tick = tick + skill_get_cooldown( skill_id, skill_lv );
 	*/

RadianFord · 2018-12-18T15:22:23Z

I noticed somethings.

If mapflag noskill are set, of course this wont work since its a skill.
Suggestion: add map_msg The Switch Feature wont work in this map.
If your character is sitting, this wont work either.
Suggestion: add map_msg The Switch Feature wont work while in sitting mode.

# Conflicts: # src/common/mmo.hpp # src/map/battle.cpp # src/map/battle.hpp # src/map/clif.cpp # src/map/clif.hpp # src/map/pc.hpp

rAthenaAPI · 2018-12-20T23:29:24Z

This pull request introduces 3 alerts when merging 8999c56 into 01f61cf - view on LGTM.com

new alerts:

3 for Comparison result is always the same

Comment posted by LGTM.com

This will remove duplicated code.

@RadianFord

Thanks to @RadianFord

@RadianFord

Tested on officials. This skill works around this mapflag. Thanks to @RadianFord

Lemongrass3110 · 2018-12-21T01:42:36Z

@RadianFord it is actually easier to reproduce.
Dagger on main window -> Katar on switch window -> switch

@RadianFord

Thanks to @RadianFord

Lemongrass3110 · 2018-12-21T01:49:22Z

So guys everything should be fixed now.
Please test it again and if no further reports come in, we can merge this to master after review.

RadianFord · 2018-12-21T01:50:31Z

@Lemongrass3110 Yeah, i just found out that tooday..

[ci skip]

@mjonrest

If a monster or anything else cast the equip switch skill it could crash the server. Thanks to @mjonrest

Removed TODOs

Thanks to everyone who contributed to this release in any way, be it donations, information or testing. Merry Christmas :-)

Initial Release of Equipment Switch

9387014

Thanks to everyone who contributed to this release in any way, be it donations, information or testing.

Lemongrass3110 added component:core mode:renewal status:code-review type:bug labels Oct 4, 2018

Disabled system by default

d1dbb71

Since our PACKETVER is not supporting it this is required for CI

Atemo reviewed Oct 4, 2018

View changes

MathReaper reviewed Oct 7, 2018

View changes

Lemongrass3110 added 2 commits Oct 11, 2018

Merge branch 'master' into feature/equip_switch

b97678d

# Conflicts: # src/map/clif.cpp # src/map/clif.hpp

Turned equip switch on by default

5316bc8

ghost referenced this issue Oct 13, 2018

SQL synchronization

7d9f953

rathena deleted a comment from Ryuhorox Oct 14, 2018

Lemongrass3110 added 6 commits Oct 16, 2018

Fixed a bug with 2 handed items

2a733e0

Fixed a wrong failure message

cc7b9f5

Replaced missing C_ITEM_EQUIP_SWITCH usage

6c3b62b

Thanks to @aleos89

Some other minor cleanups

734b34f

Found by @aleos89

Fixed some wrong index checks

a7e35ba

Merge branch 'master' into feature/equip_switch

702a0d3

Merge branch 'master' into feature/equip_switch

8999c56

# Conflicts: # src/common/mmo.hpp # src/map/battle.cpp # src/map/battle.hpp # src/map/clif.cpp # src/map/clif.hpp # src/map/pc.hpp

Lemongrass3110 added 5 commits Dec 20, 2018

Changed tick to new type t_tick

d1993e7

Fixed LGTM alerts

cfb2afe

Created a new sub function for skill usage

d2e6deb

This will remove duplicated code.

Fixed sitting

975d5a6

Thanks to @RadianFord

Fixed noskill mapflag

4868e8e

Tested on officials. This skill works around this mapflag. Thanks to @RadianFord

Lemongrass3110 added 2 commits Dec 21, 2018

Fixed a bug introduced in d2e6deb

935b8c8

Fixed a bug with multi vs 1 handed weapons

5e2f51e

Thanks to @RadianFord

Lemongrass3110 added 3 commits Dec 21, 2018

Fixed normal skill usage

42720a6

[ci skip]

Added a sanity check for non-players

e9cc2f5

If a monster or anything else cast the equip switch skill it could crash the server. Thanks to @mjonrest

Renamed sql script

ffcea7e

Removed TODOs

Lemongrass3110 merged commit 818ff10 into master Dec 24, 2018
6 checks passed

Lemongrass3110 removed the status:code-review label Dec 24, 2018

SeravySensei pushed a commit to SeravySensei/rathena that referenced this issue Jan 26, 2019

Initial Release of Equipment Switch (rathena#3548)

6f121ae

Thanks to everyone who contributed to this release in any way, be it donations, information or testing. Merry Christmas :-)

sctnightcore mentioned this pull request Mar 18, 2019

iRO Unknown switch: 0A95,0A9B,0A97,0A98,0A9C,0A9D,0A9A, OpenKore/openkore#2676

Closed

sctnightcore mentioned this pull request Mar 21, 2019

EquipSwitch Packet OpenKore/openkore#2681

Merged

SombraRO mentioned this pull request Oct 11, 2019

Equipment Switch HerculesWS/Hercules#2557

Open

Lemongrass3110 deleted the feature/equip_switch branch Aug 3, 2020

rathena / rathena Public

Initial Release of Equipment Switch #3548

Initial Release of Equipment Switch #3548

Lemongrass3110 commented Oct 4, 2018

anacondaq commented Oct 4, 2018

Lemongrass3110 commented Oct 4, 2018

Atemo Oct 4, 2018

aleos89 Oct 5, 2018

Balferian commented Oct 5, 2018 •

edited

aleos89 commented Oct 5, 2018

MathReaper commented Oct 7, 2018 •

edited

MathReaper Oct 7, 2018

Lemongrass3110 Oct 10, 2018

MathReaper Oct 11, 2018

Lemongrass3110 Oct 16, 2018

BruSantato commented Oct 7, 2018

anacondaq commented Oct 7, 2018

BruSantato commented Oct 7, 2018

MathReaper commented Oct 8, 2018

MathReaper commented Oct 11, 2018

ghost commented Oct 14, 2018

MathReaper commented Oct 14, 2018

lukasrmattos commented Oct 30, 2018

BrOgBr commented Oct 30, 2018

lukasrmattos commented Oct 30, 2018

mjonrest commented Nov 3, 2018

BruSantato commented Nov 18, 2018

RadianFord commented Dec 3, 2018

Mateuus commented Dec 7, 2018

RadianFord commented Dec 18, 2018

rAthenaAPI commented Dec 20, 2018

Lemongrass3110 commented Dec 21, 2018

Lemongrass3110 commented Dec 21, 2018

RadianFord commented Dec 21, 2018

rathena / rathena Public

Initial Release of Equipment Switch #3548

Initial Release of Equipment Switch #3548

Conversation

Lemongrass3110 commented Oct 4, 2018

anacondaq commented Oct 4, 2018

Lemongrass3110 commented Oct 4, 2018

Atemo Oct 4, 2018

Choose a reason for hiding this comment

aleos89 Oct 5, 2018

Choose a reason for hiding this comment

Balferian commented Oct 5, 2018 • edited

aleos89 commented Oct 5, 2018

MathReaper commented Oct 7, 2018 • edited

MathReaper Oct 7, 2018

Choose a reason for hiding this comment

Lemongrass3110 Oct 10, 2018

Choose a reason for hiding this comment

MathReaper Oct 11, 2018

Choose a reason for hiding this comment

Lemongrass3110 Oct 16, 2018

Choose a reason for hiding this comment

BruSantato commented Oct 7, 2018

anacondaq commented Oct 7, 2018

BruSantato commented Oct 7, 2018

MathReaper commented Oct 8, 2018

MathReaper commented Oct 11, 2018

ghost commented Oct 14, 2018

MathReaper commented Oct 14, 2018

lukasrmattos commented Oct 30, 2018

BrOgBr commented Oct 30, 2018

lukasrmattos commented Oct 30, 2018

mjonrest commented Nov 3, 2018

BruSantato commented Nov 18, 2018

RadianFord commented Dec 3, 2018

Mateuus commented Dec 7, 2018

RadianFord commented Dec 18, 2018

rAthenaAPI commented Dec 20, 2018

Lemongrass3110 commented Dec 21, 2018

Lemongrass3110 commented Dec 21, 2018

RadianFord commented Dec 21, 2018

Balferian commented Oct 5, 2018 •

edited

MathReaper commented Oct 7, 2018 •

edited