Terra Gloria (episode 16.2) - walkthrough conversion #3990

Atemo · 2019-02-28T22:06:55Z

Addressed Issue(s):
Server Mode: renewal
Description of Pull Request:

Basic and unfinished version of Terra Gloria (episode 16.2).

Unfinished

Note

To avoid exploit there are currently 2 instances of Werner Laboratory central room (officially one), the warp entry being the same. The first (main quest) is a solo instance and the 2nd (daily) a party instance. The instance is a basic version, KRO added Seyren boss fight in the next updates.

Thanks to @admkakaroto and https://www.divine-pride.net/ !

attackjom · 2019-03-01T08:09:56Z

found a problem when talk to Spica in our private room and leave the room before talk to Nihil, then those NPC will not appear again and quest will stuck in this.

attackjom · 2019-03-01T11:26:24Z

quest_16_2.txt

line 5298 : shoud use "and " not "amd"

line 6201 : should be "Special Force" not "Special_Force"

zackdreaver · 2019-03-05T06:41:51Z

@Atemo
Does iRO's quest2display for these quests has been translated?

Atemo · 2019-03-05T15:00:07Z

The quest entries are missing on IRO client.
Do you have a version translated?

zackdreaver · 2019-03-05T16:31:58Z

I'm working on it, around 50% completed, I'll resume the works tomorrow.

zackdreaver · 2019-03-06T07:52:37Z

Do quest ID from 7763 - 7769 part of this episode quest?
It's like event quest to me.

Atemo · 2019-03-06T14:02:16Z

You're right, these quests are not a part of the quest, sorry.

zackdreaver · 2019-03-07T19:21:02Z

I haven't tested this on live server, but it should be good
zackdreaver/ROenglishRE@75ffc4f

@zackdreaver

Thanks to @zackdreaver !

Badarosk0 · 2019-04-10T11:36:09Z

From what I've checked, it seems that there is no recognition that the player has completed the Banquet of Heroes quests to start the Terra Gloria quests. It does not start.
@Atemo

Atemo · 2019-04-10T13:56:21Z

From what I've checked, it seems that there is no recognition that the player has completed the Banquet of Heroes quests to start the Terra Gloria quests. It does not start.

What do you mean? You found an issue in this PR?
It seems on official server that the Terra quests can be started when the character has access to the room of consciousness instance (daily quest). There are several check in this PR for that :

	if (banquet_main_quest < 26)	// pre-req : access to room of consciousness (first time)
		end;

Badarosk0 · 2019-04-10T13:59:59Z

Yes, I realised. Even completing the instance the variable did not receive the value. I needed to change the value of the variable to (26) to continue.

Atemo · 2019-04-10T14:08:11Z

I see, the check should be if (banquet_main_quest < 25).

@Badarosk0

Thanks to @Badarosk0 !

Actually the prerequisite to start the main quest is the entrance to room of consciousness (not daily).

admkakaroto · 2019-04-12T01:01:24Z

A small contribution.
Here: admkakaroto@1a19c35

@admkakaroto

Thanks to @admkakaroto and https://www.divine-pride.net !

Badarosk0 · 2019-05-13T10:13:29Z

Map server crash: @Atemo

Program received signal SIGSEGV, Segmentation fault.
map_setcell (m=Unhandled dwarf expression opcode 0xf3
) at map.cpp:3312
3312			case CELL_SHOOTABLE:     mapdata->cell[j].shootable = flag;     break;
Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.209.el6_9.2.x86_64 keyutils-libs-1.4-5.el6.x86_64 krb5-libs-1.10.3-65.el6.x86_64 libcom_err-1.41.12-23.el6.x86_64 libgcc-4.4.7-18.el6.x86_64 libselinux-2.0.94-7.el6.x86_64 libstdc++-4.4.7-18.el6.x86_64 mysql-libs-5.1.73-8.el6_8.x86_64 nss-softokn-freebl-3.14.3-23.3.el6_8.x86_64 openssl-1.0.1e-57.el6.x86_64 pcre-7.8-7.el6.x86_64 zlib-1.2.3-29.el6.x86_64
(gdb) 
�[K(gdb) bt full
#0  map_setcell (m=Unhandled dwarf expression opcode 0xf3
) at map.cpp:3312
        j = 6116
#1  0x0000000000530c54 in map_iwall_remove (wall_name=Unhandled dwarf expression opcode 0xf3
) at map.cpp:3450
        iwall = 0x7fffd75b9dac
        i = 0
        x1 = 116
        y1 = 30
#2  0x00000000005c6737 in buildin_delwall (st=0x7fffedd6b7e4) at script.cpp:14115
        name = <value optimized out>
#3  0x00000000005c346d in run_func (st=0x7fffedd6b7e4) at script.cpp:4022
        data = <value optimized out>
        i = <value optimized out>
        start_sp = <value optimized out>
        end_sp = <value optimized out>
        func = 20892
#4  0x00000000005c84f0 in run_script_main (st=0x7fffedd6b7e4) at script.cpp:4297
        cmdcount = 655071
        gotocount = 2048
        sd = <value optimized out>
        stack = 0x7fffe9f9873c
#5  0x00000000005553f3 in npc_instanceinit (nd=0x7fffd4b9d10c) at npc.cpp:3469
        ev = 0x5924bf4
        evname = "dup_2_110020417::OnInstanceInit\000p\345n\000\000\000\000\000\000\000\000\000\245\003\000\000@.\237\000\000\000\000\000\374\276\265\331\377\177\000\000`n\370\000\000\000\000\000\000\000\000\000)"
#6  0x0000000000529974 in map_foreachinareaV(int (*)(block_list *, typedef __va_list_tag __va_list_tag *), int16, int16, int16, int16, int16, int, typedef __va_list_tag __va_list_tag *, bool) (func=0x513f70 <instance_npcinit(block_list *, typedef __va_list_tag __va_list_tag *)>, m=1065, x0=<value optimized out>, 
    y0=<value optimized out>, x1=<value optimized out>, y1=<value optimized out>, type=128, ap=<value optimized out>, wall_check=false) at map.cpp:804
        bx = <value optimized out>
        by = <value optimized out>
        cx = 0
        cy = 64
        returnCount = 0
        bl = <value optimized out>
        blockcount = <value optimized out>
        i = 82
        ap_copy = void
#7  0x0000000000529b63 in map_foreachinallarea(int (*)(block_list *, typedef __va_list_tag __va_list_tag *), int16, int16, int16, int16, int16, int, ...) (func=Unhandled dwarf expression opcode 0xf3
)
    at map.cpp:820
        returnCount = 0
        ap = void
#8  0x0000000000514473 in instance_addnpc (im=0x9f2e40) at instance.cpp:358
        mapdata = <value optimized out>
        i = 0
#9  0x0000000000514687 in instance_addmap (instance_id=2) at instance.cpp:527
        i = <value optimized out>
        m = <value optimized out>
        im = 0x9f2e40
        db = 0x7fffeaf96744
        entry = <value optimized out>
#10 0x00000000005147cd in instance_addmap (tid=Unhandled dwarf expression opcode 0xf3
) at instance.cpp:115
No locals.
#11 instance_subscription_timer (tid=Unhandled dwarf expression opcode 0xf3
) at instance.cpp:119
        i = <value optimized out>
        ret = <value optimized out>
        instance_id = 2
        sd = 0x0
        pd = 0x0
        gd = 0x0
        cd = 0x0
        mode = <value optimized out>
#12 0x0000000000514bf7 in instance_create (owner_id=51064, name=0x7fffde561c29 "Heart Hunter War Base 2", mode=IM_PARTY) at instance.cpp:456
        db = <value optimized out>
        sd = 0x0
        pd = 0x7fffd63b2964
        gd = 0x0
        cd = 0x0
        i = 2
        __FUNCTION__ = "instance_create"
#13 0x00000000005de3d1 in buildin_instance_create (st=0x7fffedd6bd04) at script.cpp:21210
        mode = <value optimized out>
        owner_id = 51064
        __FUNCTION__ = "buildin_instance_create"
#14 0x00000000005c346d in run_func (st=0x7fffedd6bd04) at script.cpp:4022
        data = <value optimized out>
        i = <value optimized out>
        start_sp = <value optimized out>
        end_sp = <value optimized out>
        func = 20945
#15 0x00000000005c84f0 in run_script_main (st=0x7fffedd6bd04) at script.cpp:4297
        cmdcount = 655339
        gotocount = 2045
        sd = <value optimized out>
        stack = 0x7fffe9f963ec
#16 0x000000000054db29 in npc_scriptcont (sd=0x7c0b170, id=110020088, closing=false) at npc.cpp:1428
        target = 0x7fffde168984
        __FUNCTION__ = "npc_scriptcont"
#17 0x00000000004cb5a8 in clif_parse (fd=Unhandled dwarf expression opcode 0xf3
) at clif.cpp:21779
        cmd = 184
        packet_len = 7
        sd = 0x7c0b170
        pnum = 0
#18 0x00000000006885dd in do_sockets (next=Unhandled dwarf expression opcode 0xf3
) at socket.cpp:1408
        rfd = {fds_bits = {4194304, 0 <repeats 15 times>}}
        timeout = {tv_sec = 0, tv_usec = 10792}
        ret = 0
        i = 22
#19 0x000000000046dda5 in main (argc=1, argv=0x7fffffffde28) at core.cpp:369
        next = <value optimized out>

Atemo · 2019-05-13T17:13:53Z

The issue seems related to delwall command if you know the step please open a new issue to keep the PR cleaner ;)

Badarosk0 · 2019-05-13T19:48:04Z

At some point I created a custom instance using delwall and my map server was always knocked over. This problem occurred whenever several people did the instance at the same time. Whenever I tested on the test server individually this did not happen. I was thinking that I was using the command incorrectly, so I removed wall from my script for the problem to stop occurring. It looks like these script wall with instance are not matched well.
#4032

AsurielRO · 2019-06-19T06:13:26Z

missing 1 monster
source > https://www.divine-pride.net/database/monster/3826

Atemo · 2019-06-19T10:22:03Z

This version doesn't have the script to summon seyren. For now it's not useful to implement it

DepTrai92 · 2019-08-25T18:20:33Z

hopefully can have Werner Laboratory central room instance work.
i missing this instance,other all i have it

admkakaroto · 2020-04-08T20:01:35Z

Please update, Atemo-san!

… the instance

* Not removed on change map * Not removed on log out * Removed on death

* Updated Build Up Potion XX item script * Corrected some aegis item name - episode 16.2

…g the new script command

@JohnnyPlayy

* Implemented "Veteran's small memorial service quest" (Ericsson daily quest) thanks to @JohnnyPlayy ! * Update Milo River quest * Added the missing texts for the quest 16022 given by Jana Levedeva

src/map/status.cpp

rye305 · 2020-08-23T16:29:17Z

Is the YSF01 Seyren daily missing?

quests_16_2.txt
Line 3489

Atemo · 2020-08-23T17:04:25Z

The Werner Laboratory central room instance is a basic version, it doesn't have the fight against Seyren. I don't have the data for the quest/instance so I let it like that for now.

Now the buffs are not removed by dispell/clearance/Vanishing Buster

@Badarosk0

Added the missing texts for Elena vs Priest (thanks to @Badarosk0)

Atemo · 2020-08-28T14:15:59Z

Any last review before merging?

src/map/skill.cpp

@aleos89

Thanks to @aleos89 !

saya9200 · 2020-09-24T17:09:46Z

currently running this on clean rA

the instance is stuck.

1@swat,163,58,0 script Pile of gunpowder#2 4_ENERGY_YELLOW,{
if ('event != 3)
end;
'event = 4;
specialeffect EF_COIN;
disablenpc instance_npcname("Pile of gunpowder#2");
initnpctimer;
end;
OnTimer1000:
stopnpctimer;
for ( .@i = 0; .@i < 5; .@i++ )
makeitem 25154,1,'map_swat$, rand(161,165), rand(51,55);// Antique_Powder
end;
}

I was on @speed 1
Killed monsters very fast.

Now clicking the pile of gunpowder does nothing and the instance cant progress.

edit:
Did it again slowly now, clicking it still does nothing.

Dieby · 2021-03-01T16:47:40Z

Update daily mission YSF01 Seyren please quests_16_2 please

Dieby · 2021-03-07T05:00:18Z

mes "[Rookie]";
mes "Shall we leave now?";
cutin "16loo_01.bmp",2;
next;
switch( select( "About the monster in the central room", "Leave.", "Stay.", "About YSF01" ) ) {
case 1:
	break;
case 2:
	mes "[Rookie]";
	mes "Follow me, then.";
	close2;
	warp "ein_fild04",279,339;
	end;
case 3:
	mes "[Rookie]";
	mes "Since this fuss is likely to continue for a while, we'd be glad if you would stay here and help us~";
	close3;
case 4:
	mes "[Rookie]";
	mes "Why did Werner do that?";
	mes "I don't understand.";
	mes "... No. Maybe it's weird to understand a lunatic.";
	next;
	mes "[Rookie]";
	mes "Anyways, We have to observe the central room's core.";
	mes "As long as there are magic inside, the same thing will happen again.";
	close3;
}

YSF01 Seyren daily
quests_16_2.txt
Line 3489

Update Please

Atemo · 2021-03-07T14:37:28Z

I don't have the data for YSF01 hunting quest.

Atemo added 2 commits Feb 28, 2019

Initial release of Terra Gloria - ep 16.2

a8289d1

Enabled monster spawn file

ebbc722

Atemo added component:script status:need more info status:code-review labels Feb 28, 2019

Fixed an issue and several typo thanks to @attackjom !

b1e1994

Added the quests name in quest_db and script side

38420e1

Thanks to @zackdreaver !

Atemo added 2 commits Apr 10, 2019

Adjusted the pre-required to start the main quest.

73edcf3

Thanks to @Badarosk0 !

Follow-up rathena@73edcf3

9db74fb

Actually the prerequisite to start the main quest is the entrance to room of consciousness (not daily).

Updated monsters DB

b98442f

Thanks to @admkakaroto and https://www.divine-pride.net !

Merge branch 'master' into script/ep16_2

7e82184

Atemo added 3 commits Apr 8, 2020

Merge branch 'master' into script/ep16_2

448b0d6

Added 16.2 instances to yml file

2e789bd

Removed the old instance_db file and added the previous comment about…

25a748d

… the instance

sader1992 mentioned this pull request Apr 28, 2020

delete_timer error : function mismatch #4856

Closed

Atemo added 10 commits Aug 12, 2020

Merge branch 'master' into script/ep16_2

b46d525

Implemented SC_EP16_2_BUFF_SS, SC_EP16_2_BUFF_SC, SC_EP16_2_BUFF_AC buff

3f27f00

* Not removed on change map * Not removed on log out * Removed on death

Moved the dummy npcs in global_npcs.txt

e619dbb

Updated item_db.txt

42f92c6

* Updated Build Up Potion XX item script * Corrected some aegis item name - episode 16.2

Updated the monsters database from this episode (data from aegis and DP)

c37414b

Small script update of the heart hunter and werner lab instances usin…

7f296d7

…g the new script command

* questinfo update

9c1ef2e

* Implemented "Veteran's small memorial service quest" (Ericsson daily quest) thanks to @JohnnyPlayy ! * Update Milo River quest * Added the missing texts for the quest 16022 given by Jana Levedeva

Several corrections

6a5fa2d

Merge branch 'master' into script/ep16_2

0e73a79

SQL synchronisation

c3701fd

aleos89 reviewed Aug 22, 2020

View changes

src/map/status.cpp Show resolved Hide resolved

Atemo added 2 commits Aug 28, 2020

Updated SC_EP16_2_BUFF_XX buffs

4d3aef8

Now the buffs are not removed by dispell/clearance/Vanishing Buster

Small updates of Ericsson daily quest

3c867d6

Added the missing texts for Elena vs Priest (thanks to @Badarosk0)

aleos89 reviewed Aug 28, 2020

View changes

src/map/skill.cpp Outdated Show resolved Hide resolved

Fixed a mistake

6e439aa

Thanks to @aleos89 !

aleos89 approved these changes Aug 28, 2020

View changes

Atemo merged commit 07cac12 into rathena:master Aug 28, 2020
4 checks passed

Atemo deleted the script/ep16_2 branch Aug 28, 2020

rathena / rathena Public

Terra Gloria (episode 16.2) - walkthrough conversion #3990

Terra Gloria (episode 16.2) - walkthrough conversion #3990

Atemo commented Feb 28, 2019 •

edited

attackjom commented Mar 1, 2019 •

edited

attackjom commented Mar 1, 2019

zackdreaver commented Mar 5, 2019

Atemo commented Mar 5, 2019 •

edited

zackdreaver commented Mar 5, 2019

zackdreaver commented Mar 6, 2019

Atemo commented Mar 6, 2019

zackdreaver commented Mar 7, 2019

Badarosk0 commented Apr 10, 2019

Atemo commented Apr 10, 2019

Badarosk0 commented Apr 10, 2019

Atemo commented Apr 10, 2019

admkakaroto commented Apr 12, 2019

Badarosk0 commented May 13, 2019

Atemo commented May 13, 2019

Badarosk0 commented May 13, 2019 •

edited

AsurielRO commented Jun 19, 2019

Atemo commented Jun 19, 2019

DepTrai92 commented Aug 25, 2019

admkakaroto commented Apr 8, 2020 •

edited

rye305 commented Aug 23, 2020

Atemo commented Aug 23, 2020

Atemo commented Aug 28, 2020

saya9200 commented Sep 24, 2020 •

edited

Dieby commented Mar 1, 2021 •

edited

Dieby commented Mar 7, 2021

Atemo commented Mar 7, 2021

rathena / rathena Public

Terra Gloria (episode 16.2) - walkthrough conversion #3990

Terra Gloria (episode 16.2) - walkthrough conversion #3990

Conversation

Atemo commented Feb 28, 2019 • edited

Unfinished

Note

attackjom commented Mar 1, 2019 • edited

attackjom commented Mar 1, 2019

zackdreaver commented Mar 5, 2019

Atemo commented Mar 5, 2019 • edited

zackdreaver commented Mar 5, 2019

zackdreaver commented Mar 6, 2019

Atemo commented Mar 6, 2019

zackdreaver commented Mar 7, 2019

Badarosk0 commented Apr 10, 2019

Atemo commented Apr 10, 2019

Badarosk0 commented Apr 10, 2019

Atemo commented Apr 10, 2019

admkakaroto commented Apr 12, 2019

Badarosk0 commented May 13, 2019

Atemo commented May 13, 2019

Badarosk0 commented May 13, 2019 • edited

AsurielRO commented Jun 19, 2019

Atemo commented Jun 19, 2019

DepTrai92 commented Aug 25, 2019

admkakaroto commented Apr 8, 2020 • edited

rye305 commented Aug 23, 2020

Atemo commented Aug 23, 2020

Atemo commented Aug 28, 2020

saya9200 commented Sep 24, 2020 • edited

Dieby commented Mar 1, 2021 • edited

Dieby commented Mar 7, 2021

Atemo commented Mar 7, 2021

Atemo commented Feb 28, 2019 •

edited

attackjom commented Mar 1, 2019 •

edited

Atemo commented Mar 5, 2019 •

edited

Badarosk0 commented May 13, 2019 •

edited

admkakaroto commented Apr 8, 2020 •

edited

saya9200 commented Sep 24, 2020 •

edited

Dieby commented Mar 1, 2021 •

edited