Update Itemdb (Ragcan's JRO item) #4115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
attackjom
commented
Apr 16, 2019
- Addressed Issue(s): -
- Server Mode: Renewal
- Description of Pull Request:
- Implement bLongSPGainvalue and bLongHPGainvalue
- Add new RC2 that use in itemscript
- Ragcan's JRO itemdb
- Info take from
- manual translate from JRO/IRO page of each item https://www.divine-pride.net/
- Sigma's translation in divine-pride forum (changelog section)
|
Thanks @attackjom |
done. |
MrLekkz
reviewed
Apr 18, 2019
| @@ -349,6 +379,19 @@ | |||
| 2990:2991,{ bonus bAllStats,5; bonus5 bAutoSpellWhenHit,"SC_MAELSTROM",1,100,BF_MAGIC,0; } | |||
| 2995:15110,{ bonus2 bSkillAtk,"NC_AXEBOOMERANG",100; } | |||
| 2997:2999,{ bonus2 bAddClass,Class_All,10; bonus bMatkRate,10; } | |||
| 32242:18971,{ bonus2 bFixedCastrate,"RK_STORMBLAST",-100; } | |||
| 32242:18973,{ bonus2 bSkillAtk,"NC_FLAMELAUNCHER",70; bonus2 bSkillAtk,"NC_COLDSLOWER",70; } | |||
There was a problem hiding this comment.
on iRO, Old Detachments Ring has a set bonus with Old Mitra (18972) (50% hp bonus)
32242:18972,{ bonus bMaxHPrate,50; }
can't confirm if its iRO exclusive or not
There was a problem hiding this comment.
It seem I forget that haha.
Thanks to @Angelic234
+ giant lance + gigantic bow + giant axe
Angelic234
reviewed
May 3, 2019
| 28430,Arch_Bishop_Ring,Arch Bishop Ring,4,20,,400,,0,,1,0xFFFFFFFF,63,2,136,,90,0,0,{ bonus bLuk,2; bonus bFlee2,5; bonus bUseSPrate,-5; bonus bHealPower,15; bonus bAddItemHealRate,15; },{},{} | ||
| 28433,Luminous_Blue_Stone,Luminous Blue Stone,4,20,,400,,0,,1,0xFFFFFFFF,63,2,136,,90,0,0,{ bonus bAgi,2; bonus bCritical,5; bonus bAspdRate,5; bonus bCritAtkRate,2; skill "MG_SIGHT",1; if (readparam(bLuk)>=100) { bonus bCritical,10; bonus bCritAtkRate,10; } },{},{} | ||
| 28434,Fist_Fighter_Glove,Fist Fighter's Glove,4,20,,400,,0,,1,0xFFFFFFFF,63,2,136,,90,0,0,{ bonus bStr,2; bonus bMaxSP,100; bonus2 bAddClass,Class_All,2; skill "MO_ABSORBSPIRITS",1; if (readparam(bStr)>99) bonus2 bAddClass,Class_All,5; },{},{} | ||
| 28437,Hibram's_Gloves,Hibram's Gloves,4,20,,400,,0,,1,0xFFFFFFFF,63,2,136,,90,0,0,{ skill "AL_HEAL",3; bonus bInt,2; bonus bMatkRate,2; bonus bUseSPrate,-5; if (readparam(bInt>=100)) bonus bMatkRate,5; },{},{} |
There was a problem hiding this comment.
if (readparam(bInt>=100)) should be if (readparam(bInt)>=100)
|
hmm why did you close the PR? |
|
Mistake in editing master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.