Implemented Star Emperor and Soul Reaper classes #4386

aleos89 · 2019-10-02T17:27:41Z

Addressed Issue(s): N/A
Server Mode: Renewal
Description of Pull Request:
- Initial implementation of these two classes.
- Takeover of #3893 and #3994.
  Thanks to @Rytech2, @Mateuus, and @nubspixel!

@Rytech2

* Initial implementation of these two classes. Thanks to @Rytech2, @Mateuus, and @nubspixel!

src/map/skill.cpp

@exneval

* Fixed Book of Creating Star not doing any damage. * Removed an extra break. Thanks to @exneval, @idamonli, and @hotspicy945!

idamonli · 2019-10-05T09:19:28Z

sce->val2: ID or tick???

idamonli · 2019-10-05T09:21:40Z

The key to the problem is "val2"

aleos89 · 2019-10-07T13:03:14Z

These values are correct, not sure what you're implying. The source object ID (caster) is passed through val2.

hotspicy945 · 2019-10-07T14:23:06Z

But in this commit(7e2fe1a) still no damage.

I test player at "prontera" & print value.

sce->val2 always 90
star_caster->m = other map
bl->m = prontera

And I found in
status.cpp
val2 = 90; // Move speed reduction

Maybe the star_caster = map_id2bl(sce->val2) found wrong data?

src/map/status.cpp

@idamonli

* Cleaned up skill database names. * Cleaned up max job level checks. * Corrected Purification of Sun, Moon and Star to no longer adjust ASPD, just the view distance. * Corrected Book of Creating Star movement speed adjustment value overwriting caster data. Thanks to @idamonli and @hotspicy945!

src/map/skill.cpp

@hotspicy945

* Book of Dimension combined with Advent of the Star Emperor should give two defensive shields equal the the caster's max SP. Thanks to @hotspicy945!

ecdarreola · 2019-10-08T14:49:04Z

What is the normal behavior of casting this skill when being hit by a player? Should the skill SJ_STAREMPEROR continue the animation or should it not?

aleos89 · 2019-10-08T15:43:50Z

I’m not sure. I haven’t played either of these classes yet, I’m just going off of info given to me so far. I saw 3CeAM uses the Millennium Shield effect.

ecdarreola · 2019-10-08T15:46:13Z

Saw that also.

There's a weird behavior on the skill SJ_STAREMPEROR wherein if you cast it and got hit, the animation continues and then your character disappear on screen for a period of time.

While not appearing on screen, you can still walk normally and cast skills normally.

And after a period of time, your character reappears on the screen like nothing happened.

Not sure if this is an official behavior though. Hehehe.

Balferian · 2019-10-09T15:44:31Z

Need to fix SG_DEVIL status:
Now if SG_DEVIL = 10 lvl aspd up to 193.
It should working like a SCB_ASPD bonus and give 11% at 10 skill lv.
[SKID.SG_DEVIL] = {
"태양과 달과 별의 악마",
"MAX Lv : 10",
"^777777습득조건 : 잡레벨 50^000000",
"계열 : ^777777패시브^000000",
"내용 : ^777777잡렙50이 됐을때만 발동하는 패시브 스킬입니다.",
"자신의 시력을 영원히 희생하는 대신에 공속을 향상시킵니다.",
"시력이 상실되면 주변이 안보여서 불편하니 가능하면 않찍는걸 권장합니다.^000000",
" [Lv 1] ^777777공속 2% 향상^000000",
" [Lv 2] ^777777공속 3% 향상^000000",
" [Lv 3] ^777777공속 4% 향상^000000",
" [Lv 4] ^777777공속 5% 향상^000000",
" [Lv 5] ^777777공속 6% 향상^000000",
" [Lv 6] ^777777공속 7% 향상^000000",
" [Lv 7] ^777777공속 8% 향상^000000",
" [Lv 8] ^777777공속 9% 향상^000000",
" [Lv 9] ^777777공속 10% 향상^000000",
"[Lv 10] ^777777공속 11% 향상^000000"
},
Tested on kRo.
AGI = 1

AGI = 99

Update:
moved to another issue #4402

voyfmyuh · 2019-10-10T07:46:24Z

Star Emperor and Soul Reaper can be equipped with 3rd job equipment such as Temporal Dex Boots

RadianFord · 2019-10-10T21:46:13Z

@aleos89 what client does these classes supports?

ghost · 2019-10-10T21:48:08Z

@RadianFord New classes are available in 2017+ client. (Recommended : 2018-06-20+)

RadianFord · 2019-10-10T21:51:59Z

@RadianFord New classes are available in 2017+ client. (Recommended : 2018-06-20+)

Thanks! I'll just wait until its merged into the master repo.

src/map/status.cpp

@hotspicy945

* After 7 attacks the hidden state should be removed. * Added missing 1 SP / second drain. * Casting the skill a second time will cancel the hidden state. * General cleanups. Thanks to @hotspicy945!

* Updated a couple skills from post kRO balancing patch: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3921697

src/map/battle.cpp

sader1992 · 2019-11-22T04:29:23Z

According to divine-pride
https://www.divine-pride.net/database/skill/2585
The enemies in the air can not attack or move
not sure but i think it means cannot cast skills while in SC_GRAVITYCONTROL

also in the korean text version in divine-pride
허공에 뜬 적은 공격 및 이동을 할 수 없으며, 데미지 및 상태이상에 면역상태가 된다.
Enemies in the air cannot attack or move, Become immune to damage and abnormalities. (According to google translate)

right now you can use skills and get attacked while in the skill in this pr

attackjom · 2019-11-26T18:21:43Z

need to update t_tickime to tick_time in status.cpp

admkakaroto · 2019-11-28T23:03:26Z

crash:

Program terminated with signal 11, Segmentation fault.
#0  0x0000000000613c80 in status_change_timer (tid=<optimized out>, tick=290410965,
    id=<optimized out>, data=725) at status.cpp:13965
13965                           if (!check_distance_bl(bl, unity_src, 11))
Missing separate debuginfos, use: debuginfo-install glibc-2.17-260.el7_6.6.x86_64 keyutils-libs-1.5.8-3.el7.x86_64 krb5-libs-1.15.1-37.el7_6.x86_64 libcom_err-1.42.9-13.el7.x86_64 libgcc-4.8.5-36.el7_6.2.x86_64 libselinux-2.5-14.1.el7.x86_64 libstdc++-4.8.5-36.el7_6.2.x86_64 mariadb-libs-5.5.60-1.el7_5.x86_64 openssl-libs-1.0.2k-16.el7_6.1.x86_64 pcre-8.32-17.el7.x86_64 zlib-1.2.7-18.el7.x86_64
(gdb) bt full
#0  0x0000000000613c80 in status_change_timer (tid=<optimized out>, tick=290410965,
    id=<optimized out>, data=725) at status.cpp:13965
        unity_src = 0x0
        dounlock = false
        sc = 0x83b2600
        sce = 0x8118138
        type = SC_SOULUNITY
        sd = 0x83b2030
        interval = 0
        status = 0x83b2594
        __FUNCTION__ = "status_change_timer"
        bl = 0x83b2030
        sc_timer_next = {<std::_Maybe_unary_or_binary_function<void, long>> = {<std::unary_function<long, void>> = {<No data fields>}, <No data fields>}, <std::_Function_base> = {
            static _M_max_size = 16, static _M_max_align = 8, _M_functor = {_M_unused = {
                _M_object = 0x9c9eed0, _M_const_object = 0x9c9eed0,
                _M_function_pointer = 0x9c9eed0,
                _M_member_pointer = (void (std::_Undefined_class::*)(std::_Undefined_class * const)) 0x9c9eed0, this adjustment 6488765},
              _M_pod_data = "\320\356\311\t\000\000\000\000\275\002c\000\000\000\000"},
            _M_manager = 0x5f2330 <std::_Function_base::_Base_manager<status_change_timer(int, t_tick, int, intptr_t)::__lambda0>::_M_manager(std::_Any_data &, const std::_Any_data &, std::_Manager_operation)>},
          _M_invoker = 0x5f1120 <std::_Function_handler<void(long int), status_change_timer(int, t_tick, int, intptr_t)::__lambda0>::_M_invoke(const std::_Any_data &, long)>}
#1  0x00000000006311b2 in do_timer (tick=<optimized out>) at timer.cpp:374
        tid = 4463
        diff = <optimized out>
        do_timer(long)::__FUNCTION__ = "do_timer"
#2  0x0000000000407645 in main (argc=1, argv=0x7ffee8285aa8) at core.cpp:368
        next = <optimized out>
(gdb)

@admkakaroto

* Added a couple checks to prevent map server crashes. * Cleaned up target check to map session data for tidiness. * Moved skill_lv to val1 in the status change to abide with standard. Thanks to @admkakaroto!

nubspixel · 2019-12-03T03:58:53Z

src->m
the src is undefined. pretty sure you meant
if (!unity_src || status_isdead(unity_src) || unity_src->m != bl->m || !check_distance_bl(bl, unity_src, 11))

Daegaladh · 2019-12-07T00:15:19Z

HP/SP tables still missing, is there any source we could use? Or should we uses SG & SL's as placeholders?

sinju92 · 2020-01-20T09:05:15Z

player inside gravity control still can get damage
its should be immune form any attack

* All damage should be blocked by the status. * Condition changes should be blocked by the status. Need to confirm if it's all or a specific list. * Cleaned up no skill cast and no movement to use SCS_NOCAST and SCS_NOMOVE. Thanks to @cahya1992!

sinju92

already tested it everything it's okay :D

xsifthewolf · 2020-02-05T15:22:44Z

soul reaper skills are not consuming spheres, nor checking for them before casting the skill ! I want to know if it's because of something in my end, I could only compile with windows 10 sdk !

src/map/status.cpp

Tutankhaten · 2020-03-10T10:30:53Z

the ability of the star emperor is not being saved.
how to reproduce: @allskill quits the game and enters again.

src/map/status.cpp

src/map/skill.cpp

@RagnaWay

Thanks to @RagnaWay!

Implemented Star Emperor and Soul Reaper classes

77db858

* Initial implementation of these two classes. Thanks to @Rytech2, @Mateuus, and @nubspixel!

aleos89 added the status:code-review label Oct 2, 2019

aleos89 mentioned this pull request Oct 2, 2019

Initial Release of Star Emperor #3893

Closed

aleos89 mentioned this pull request Oct 2, 2019

Initial release of Soul Reaper #3994

Closed

aleos89 added 2 commits Oct 2, 2019

Corrected a status change constant export

0d1cfb9

Added placeholders for pre-renewal

9ffc390

hotspicy945 reviewed Oct 4, 2019

View changes

src/map/skill.cpp Outdated Show resolved Hide resolved

Corrected Book of Creating Star

7e2fe1a

* Fixed Book of Creating Star not doing any damage. * Removed an extra break. Thanks to @exneval, @idamonli, and @hotspicy945!

hotspicy945 reviewed Oct 5, 2019

View changes

src/map/status.cpp Outdated Show resolved Hide resolved

aleos89 added 2 commits Oct 7, 2019

Removed an extra comma

38cf2a8

hotspicy945 reviewed Oct 7, 2019

View changes

src/map/skill.cpp Outdated Show resolved Hide resolved

Added missing defense bonus for Book of Dimension

422967f

* Book of Dimension combined with Advent of the Star Emperor should give two defensive shields equal the the caster's max SP. Thanks to @hotspicy945!

hotspicy945 reviewed Oct 11, 2019

View changes

src/map/status.cpp Show resolved Hide resolved

aleos89 added 2 commits Oct 11, 2019

Corrected New Moon Kick

91ab22a

* After 7 attacks the hidden state should be removed. * Added missing 1 SP / second drain. * Casting the skill a second time will cancel the hidden state. * General cleanups. Thanks to @hotspicy945!

Updated skills according to kRO updates

34c27a8

* Updated a couple skills from post kRO balancing patch: http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=3921697

AsurielRO reviewed Oct 27, 2019

View changes

src/map/battle.cpp Show resolved Hide resolved

aleos89 added 3 commits Oct 28, 2019

Added missing constants for Soul Curse status

7cc2b3f

Merge branch 'master' into feature/star_emperor_soul_reaper

3a7028b

Corrected a compile error

abaaaba

Adjusted error handling for Soul Unity

6e198e7

* Added a couple checks to prevent map server crashes. * Cleaned up target check to map session data for tidiness. * Moved skill_lv to val1 in the status change to abide with standard. Thanks to @admkakaroto!

Resolved compile error

f79d42c

viktormulinari mentioned this pull request Dec 16, 2019

Fire Bolt, Fire Ball, Fire Wall and Stone Curse Skill Failled #4479

Closed

aleos89 added 2 commits Jan 20, 2020

Merge branch 'master' into feature/star_emperor_soul_reaper

2c0a207

Cleaned up Gravitation Control

44179c4

* All damage should be blocked by the status. * Condition changes should be blocked by the status. Need to confirm if it's all or a specific list. * Cleaned up no skill cast and no movement to use SCS_NOCAST and SCS_NOMOVE. Thanks to @cahya1992!

sinju92 approved these changes Jan 21, 2020

View changes

This comment was marked as spam.

Sign in to view

Merge branch 'master' into feature/star_emperor_soul_reaper

a0c5300

Merge branch 'master' into feature/star_emperor_soul_reaper

bcea848

Angelic234 reviewed Feb 9, 2020

View changes

src/map/status.cpp Outdated Show resolved Hide resolved

aleos89 added 2 commits Feb 11, 2020

Merge branch 'master' into feature/star_emperor_soul_reaper

436aecc

Cleanups from conversion

c3b461a

Akkarinage added this to Episode 16.2: Terra Gloria in Official Episode Content Feb 13, 2020

Akkarinage added this to the Official Implementation milestone Feb 13, 2020

aleos89 added 3 commits Feb 28, 2020

Merge branch 'master' into feature/star_emperor_soul_reaper

a112e07

Minor cleanups and optimizations

402c2dc

Corrects a compile error

a186f19

This comment was marked as spam.

Sign in to view

Merge branch 'master' into feature/star_emperor_soul_reaper

37aea6e

RagnaWay reviewed Mar 10, 2020

View changes

src/map/status.cpp Outdated Show resolved Hide resolved

reunite-ro reviewed Mar 11, 2020

View changes

src/map/skill.cpp Show resolved Hide resolved

Corrects a comment typo

2bb211a

Thanks to @RagnaWay!

aleos89 merged commit 412d900 into master Mar 24, 2020
6 checks passed

aleos89 deleted the feature/star_emperor_soul_reaper branch Mar 24, 2020

Daegaladh removed the status:code-review label Apr 9, 2020

rathena / rathena Public

Implemented Star Emperor and Soul Reaper classes #4386

Implemented Star Emperor and Soul Reaper classes #4386

aleos89 commented Oct 2, 2019

idamonli commented on `7e2fe1a` Oct 5, 2019

idamonli commented on `7e2fe1a` Oct 5, 2019

aleos89 commented on `7e2fe1a` Oct 7, 2019

hotspicy945 commented on `7e2fe1a` Oct 7, 2019 •

edited

ecdarreola commented on `422967f` Oct 8, 2019

aleos89 commented on `422967f` Oct 8, 2019

ecdarreola commented on `422967f` Oct 8, 2019

Balferian commented Oct 9, 2019 •

edited

voyfmyuh commented Oct 10, 2019

RadianFord commented Oct 10, 2019

ghost commented Oct 10, 2019

RadianFord commented Oct 10, 2019

sader1992 commented Nov 22, 2019 •

edited

attackjom commented Nov 26, 2019

admkakaroto commented Nov 28, 2019

nubspixel commented on `6e198e7` Dec 3, 2019

Daegaladh commented Dec 7, 2019

sinju92 commented Jan 20, 2020

sinju92 left a comment

This comment was marked as spam.

xsifthewolf commented Feb 5, 2020

This comment was marked as spam.

Tutankhaten commented Mar 10, 2020

rathena / rathena Public

Implemented Star Emperor and Soul Reaper classes #4386

Implemented Star Emperor and Soul Reaper classes #4386

Conversation

aleos89 commented Oct 2, 2019

idamonli commented on 7e2fe1a Oct 5, 2019

Choose a reason for hiding this comment

idamonli commented on 7e2fe1a Oct 5, 2019

Choose a reason for hiding this comment

aleos89 commented on 7e2fe1a Oct 7, 2019

Choose a reason for hiding this comment

hotspicy945 commented on 7e2fe1a Oct 7, 2019 • edited

Choose a reason for hiding this comment

ecdarreola commented on 422967f Oct 8, 2019

Choose a reason for hiding this comment

aleos89 commented on 422967f Oct 8, 2019

Choose a reason for hiding this comment

ecdarreola commented on 422967f Oct 8, 2019

Choose a reason for hiding this comment

Balferian commented Oct 9, 2019 • edited

voyfmyuh commented Oct 10, 2019

RadianFord commented Oct 10, 2019

ghost commented Oct 10, 2019

RadianFord commented Oct 10, 2019

sader1992 commented Nov 22, 2019 • edited

attackjom commented Nov 26, 2019

admkakaroto commented Nov 28, 2019

nubspixel commented on 6e198e7 Dec 3, 2019

Choose a reason for hiding this comment

Daegaladh commented Dec 7, 2019

sinju92 commented Jan 20, 2020

sinju92 left a comment

This comment was marked as spam.

xsifthewolf commented Feb 5, 2020

This comment was marked as spam.

Tutankhaten commented Mar 10, 2020

idamonli commented on `7e2fe1a` Oct 5, 2019

idamonli commented on `7e2fe1a` Oct 5, 2019

aleos89 commented on `7e2fe1a` Oct 7, 2019

hotspicy945 commented on `7e2fe1a` Oct 7, 2019 •

edited

ecdarreola commented on `422967f` Oct 8, 2019

aleos89 commented on `422967f` Oct 8, 2019

ecdarreola commented on `422967f` Oct 8, 2019

Balferian commented Oct 9, 2019 •

edited

sader1992 commented Nov 22, 2019 •

edited

nubspixel commented on `6e198e7` Dec 3, 2019