Script Engine Upgrade #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aleos89
commented
Jun 11, 2015
- Upgraded the script engine variables to no longer be limited.
- Increased array limit from 127 to 2 billion.
- Improvement in overall speed and storage size.
- All variable types now support arrays.
- Merge from HerculesWS/Hercules@82b583b. Thanks to those who worked on it.
* Upgraded the script engine variables to no longer be limited. * Increased array limit from 127 to 2 billion. * Improvement in overall speed and storage size. * All variable types now support arrays. - Merge from HerculesWS/Hercules@82b583b. Thanks to those who worked on it.
* Removed an unused function.
|
Increased array limit from 128* to 2 billion. also downloaded branch will respond with results tomorrow |
|
@aleos89 did several test today before work, everything seemed fine. I'll do some more complicated test when home. |
|
Thanks for the testing. There are a few memleaks on server close which I will be fixing shortly. :) |
|
@aleos89 I tested again using each variable type (NPC,Player,Account,Server) for both strings and int, up to variable array length of 30000ish. I lost the account stinged Array after server restart once (might have not saved the variable before the reset is my guess) when you update again ill try again, im already loving this feature for my mining system and login rewards scripts, |
* Cleaned up db_vdestroy errors at server shutdown. * Expanded the ERS system. Thanks to Hercules. * Added ERS to the database trees to speed up iterator memory allocation. Thanks to Hercules.
* Fixed remaining memory leak. * Cleaned up and optimized a few more ERS allocations.
* Fixed some more memory leaks. * Added a few checks that were left out/removed by mistake.
* Renamed SQL upgrade file. * Fixed a buffer overflow in 'set' atcommand.
aleos89
added a commit
that referenced
this issue
Aug 31, 2015
Script Engine Upgrade * More information here: https://rathena.org/board/topic/102946-script-engine-upgrade/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.