Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Improvement Project - Rune Knight (Part 2) #4709

Merged
merged 18 commits into from May 18, 2020
Merged

Job Improvement Project - Rune Knight (Part 2) #4709

merged 18 commits into from May 18, 2020

Conversation

aleos89
Copy link
Contributor

@aleos89 aleos89 commented Mar 11, 2020

@ecdarreola
Copy link

@ecdarreola ecdarreola commented Mar 11, 2020

Hundred Spear doesn't seem to do splash damage upon testing. Wind Cutter/Ignition Break working fine.

* Corrects Hundred Spear not doing splash damage.
Thanks to @ecdarreola!
@samers1
Copy link

@samers1 samers1 commented Mar 12, 2020

Hello, where's part 1? could you put the pull link?

@aleos89
Copy link
Contributor Author

@aleos89 aleos89 commented Mar 12, 2020

It was applied a long time ago in #2181.

src/map/battle.cpp Show resolved Hide resolved
src/map/battle.cpp Show resolved Hide resolved
@Angelic234
Copy link

@Angelic234 Angelic234 commented Mar 14, 2020

  1. use item Runstone_Lux(ID 22540)
  2. attack a monster
  3. map-server crash

@Haydrich
Copy link

@Haydrich Haydrich commented Mar 14, 2020

Lux Anima Runestone gives a chance to autospell storm blast lvl 1
actually shouldn't works with skills.
just when use auto attack with weapon.

When you use lux anima stone then use a skill like Dragon breath, map-serv crash

* Moves damage calculation to generic battle calculation function.
* Resolves the Storm Blast bonus also applying to skill attacks.
Haydrich
Copy link

@Haydrich Haydrich commented on 7c9e9fb Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working
when activite Lux Anima Runestone
gives bonus hp sp critical damage but not autospell stormblast!

Haydrich
Copy link

@Haydrich Haydrich commented on c70e3fa Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Error when recompiling

* Moves check to a better location.
Haydrich
Copy link

@Haydrich Haydrich commented on 87f6b51 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally works fine.
great work

@LordWhiplash
Copy link
Contributor

@LordWhiplash LordWhiplash commented Mar 27, 2020

In hundred spears change, HitCount is 5, this doesnt means that it will hit 5 times with the full damage on each hit? isn't it supposed to be -5 and divide full damage in five hits?

@ecdarreola
Copy link

@ecdarreola ecdarreola commented Apr 10, 2020

Storm blast processed by SC_LUXANIMA is abnormal. It multiplies by the number of hits or number of mobs on the area.

Not sure if this is the official behavior however when I test the Pertz Runestone, storm blast doesn't multiply its hit but only once.

Video: https://youtu.be/Q10zwyY2qPk

* Lux Anima was casing Storm Blast multiple times based on the amount of targets in the area.
Thanks to @ecdarreola!
@LordWhiplash
Copy link
Contributor

@LordWhiplash LordWhiplash commented Apr 20, 2020

lux anima effect is missing this buffs:
+30% physical damage against all enemies sizes
+30% critical damage
+30% melee physical damage
+30% long ranged physical damage

@LordWhiplash
Copy link
Contributor

@LordWhiplash LordWhiplash commented Apr 23, 2020

Physical damage against all enemies sizes is working great, thanks!
but the +30% critical damage, +30% melee physical damage, and +30% long ranged physical damage are still missing

@LordWhiplash
Copy link
Contributor

@LordWhiplash LordWhiplash commented Apr 28, 2020

Now is working fine, thanks!

@Masao87
Copy link

@Masao87 Masao87 commented May 18, 2020

Do you have any ETA on this maybe? :)

@aleos89 aleos89 merged commit 44e5c5b into master May 18, 2020
6 checks passed
@aleos89 aleos89 deleted the update/rune_knight branch May 18, 2020
SeravySensei added a commit to SeravySensei/rathena that referenced this issue Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants