Initial support for newer packet versions

[Lemongrass3110]

• Addressed Issue(s): #3925, #4419

• Server Mode: Both

• Description of Pull Request:
  Basic support for packets up to April 2020
  Changing the default packet version to 2020-04-01

Special thanks and credits to @4144 for keeping the basic packet data updated and maintaining it
as well as to @shennetsind for the initial design idea.

Not all features are supported yet - please refrain from asking for them in here.
Some clients < 2010 are still broken and will be fixed during the code review / testing time.

[alisonrag]

Error Hexed 2020 03 18

[Info]: 'Testeee' logged in. (AID/CID: '2000001/150002', IP: '127.0.0.1', Group '99').
[Warning]: clif_parse: Received unsupported packet (packet 0x0b6d, 6 bytes received), disconnecting session #3.
[Info]: Character 'Testeee' logged off.

when clicking on the shop

the hexed 2020 04 01 I can't use the keyboard.

I have the same error. Testing in 2020-02-06
[Warning]: clif_parse: Received unsupported packet (packet 0x0b6d, 6 bytes received), disconnecting session #15.

To enable keyboard, the packet 0B1B must be sended from server to client after hotkey list

OpenKore/openkore#3074

[lgtm-com]

This pull request introduces 12 alerts and fixes 1 when merging d4cb015 into 5154e07 - view on LGTM.com

new alerts:

• 10 for Wrong type of arguments to formatting function
• 1 for Comparison result is always the same
• 1 for Comparison of narrow type with wide type in loop condition

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[lgtm-com]

This pull request fixes 1 alert when merging 123f266 into 5154e07 - view on LGTM.com

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[Balferian]

It is crashing when clicking on the (Adventurer's agent) icon.
Is there a way to add a restriction to avoid the crash?

I test it on 2020-04-01 exe + last kRo client and don`t see server/client crash.

[Balferian]

I test it on 2020-04-01 exe + last kRo client and don`t see server/client crash.

Don't give an error to you when clicking the button?

I didn`t update my msgstring yet, but window open

[ecdarreola]

I'm unable to use skill or use macro in-game like "alt+s" and "alt+m", am I missing something with the PR? or is it client related files?

[alisonrag]

I'm unable to use skill or use macro in-game like "alt+s" and "alt+m", am I missing something with the PR? or is it client related files?

Missing 0B1B

Check my comment:
#4944 (comment)

@Lemongrass3110 can u check this?

[Balferian]

Client 2020-04-01

1. After change job skills don`t remove from skill bar (need relogin).
2. If player use refresh, impossible to use hot keys F1-F9 / ALT+...
   (looks like client want some packet or problem in refresh command in new client)
3. Attandance window doesn`t open.
4. If change config in game "데미지 표기 확장" to show damage digits are croped.
   
5. Guild icons don`t work.
   
6. Items don`t add from cash shop to inventory when deal is confirmed.
   ([Warning]: Player 150000 sent incorrect cash shop buy packet (len 20:24)!)
7. Need to update Madogear packets to send params: 0 - old mado / 1 - new mado, for now mado don`t show on character.
8. When player try to take items from mail client crashed (only with this button).
   After relogin items are in inventory.
   

[lgtm-com]

This pull request fixes 1 alert when merging 8ee4a85 into cd0937c - view on LGTM.com

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[Feelmeone]

Equipment is not displayed when viewing the equipment window of another character.

[admkakaroto]

Equipment is not displayed when viewing the equipment window of another character.

I confirm, client 20200401

[lgtm-com]

This pull request fixes 1 alert when merging 27dc22b into 6c5ed52 - view on LGTM.com

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[LolyAll]

There is another bug, when you put items in the merchant's cart, not all items appear, you need to use @refresh to appear, some appear, I will record a video to show how the bug is.

[qwerty7vp]

There is another bug, when you put items in the merchant's cart, not all items appear, you need to use @refresh to appear, some appear, I will record a video to show how the bug is.

I comfirm this

some items disappear when put them in cart
and came back after @refresh or relogin

[lgtm-com]

This pull request fixes 1 alert when merging 36b1b20 into 6c5ed52 - view on LGTM.com

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[lgtm-com]

This pull request fixes 1 alert when merging a6e55a5 into 929c30c - view on LGTM.com

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[lgtm-com]

This pull request fixes 1 alert when merging e4a4cbb into 929c30c - view on LGTM.com

fixed alerts:

• 1 for Comparison of narrow type with wide type in loop condition

[Haydrich]

Client side: 20200401
Issue: when using an item gives an Enable Skill ex: 28502 after take the item off the skill stuck in the skill bar 'but unable to use it'
1- @item 28502
2- wear it
3- Alt+s and check Other Skills
4- put the new skill in Skill Bar
5- take the item off
6- check if the Skill still in the bar or disappeared

[admkakaroto]

Skill bar are not auto refreshing.

[M45T3Ryu]

Guild icons requires an external web service to provide upload and download API to function.
Yesterday I've spun up an experimental project for this use case. Please help me test it. Thanks :)

https://github.com/secretdataz/athena-web-service

edit: yes, there's no documentation, for now

cc @Balferian

Shoudnl't this be included with rA? Maybe a custom simpler module? That sends the data over that port

Maybe even compatibilize the current SQL decoding for downstreaming the icons?

[Razgrom]

noticed a problem with one of the skills RG - Earth Drive. After using it, there is a problem with the walk delay. if immediately after the skill, start moving, then his first steps do not go as usual, but the problem with animation. He makes at once in the region of 10-15 steps.It seems that this should not be so.