Lemongrass3110 Mar 22, 2022

Should be moved into a define and increased. Problems were reported already. Applies to all buffers and their SQL counterparts.

Outdated

src/web/userconfig_controller.cpp

Lemongrass3110 Mar 22, 2022

REPLACE INTO?

src/web/userconfig_controller.cpp

Lemongrass3110 Mar 22, 2022

Should be moved into a define and increased. Problems were reported already. Applies to all buffers and their SQL counterparts.

Outdated

src/web/merchantstore_controller.cpp

Lemongrass3110 Mar 22, 2022

Should be moved somewhere else i guess. Old BMP limit is 2048 it seems.

src/web/emblem_controller.cpp

Lemongrass3110 Mar 22, 2022

Again: REPLACE INTO?

src/web/merchantstore_controller.cpp

Lemongrass3110 Mar 22, 2022

Why is this needed here in the header?

Outdated

src/web/http.hpp

Lemongrass3110 Mar 22, 2022

I would have loved to see this making use of C++, but we can change that later on.

src/web/http.hpp

Lemongrass3110 Mar 22, 2022

Is it ok to "reuse" the stmt here without freeing the old one?

src/web/emblem_controller.cpp

Lemongrass3110 Mar 22, 2022

Please add a TODO mark here for the transparency check.

src/web/emblem_controller.cpp

Lemongrass3110 Mar 22, 2022

Messages contain "download" and should be "upload".

Outdated

src/web/emblem_controller.cpp

Lemongrass3110 Mar 22, 2022

Just a stupid thought: REPLACE INTO?

src/web/charconfig_controller.cpp

Lemongrass3110 Mar 22, 2022

Should be moved into a define and increased. Problems were reported already. Applies to all buffers and their SQL counterparts.

Outdated

src/web/charconfig_controller.cpp

Lemongrass3110 Mar 22, 2022

```suggestion ShowDebug("Web Auth Token for account %d was disabled\n", id); ```

Outdated

src/login/account.cpp

Lemongrass3110 Mar 22, 2022

Maybe move into conf?

Outdated

src/login/account.hpp

Lemongrass3110 Mar 22, 2022

Better move this to src\config\packets.hpp and change it to the style that is used at the bottom of the file? Also should this be respected in login-server as well for the token creation itself too?

Outdated

src/config/const.hpp

Lemongrass3110 Mar 22, 2022

If i see it correctly compiling and linking order has been switched. Is this really necessary?

configure

Lemongrass3110 Mar 22, 2022

Maybe move both configs: ``` // Do we allow to change guilde emblem during woe_time? emblem_woe_change: yes // How many transparent pixel can be found in emblem before detected as invalid? (Note 2) emblem_transparency_limit: 80 ``` from conf\battle\client.conf into inter.conf to have it accessible in both map-server and web-server without having duplicate locations. Also for backward compatability issues?

Outdated

conf/web_athena.conf

Lemongrass3110 Mar 22, 2022

```suggestion httplib - library for http web service (https://github.com/vstumpf/cpp-httplib/commit/0ec9c56e85251ff167fc1935dd1d64e795c08e6e) ```

Outdated

3rdparty/README.txt

Lemongrass3110 Apr 27, 2021

Maybe also go for alphabetical order here.

Outdated

3rdparty/CMakeLists.txt

Lemongrass3110 Apr 27, 2021

Please include the git hash or version number - this has been a problem in the past already.

Outdated

3rdparty/README.txt

aleos89 Apr 20, 2021

```suggestion ShowStatus("The web-server is " CL_GREEN "ready" CL_RESET " (Server is listening on the port %u).\n\n", web_config.web_port); ```

Outdated

src/web/web.cpp

aleos89 Apr 20, 2021

```suggestion ShowError("Web server hasn't started, stopping.\n"); ```

Outdated

src/web/web.cpp

aleos89 Apr 20, 2021

```suggestion ShowDebug("Web server not running, sleeping 1 second.\n"); ```

Outdated

src/web/web.cpp

aleos89 Apr 20, 2021

Is this something we should macro to 10 seconds? Or should we turn this into a while loop to keep trying?

src/web/web.cpp

aleos89 Apr 20, 2021

```suggestion #include "emblem_controller.hpp" #include "http.hpp" #include "userconfig_controller.hpp" ```

Outdated

src/web/web.cpp

aleos89 Apr 20, 2021

```suggestion ShowDebug("[AccountID: %d, World: \"%s\"] Not found in table, sending new info.\n", account_id, world_name); ```

Outdated

src/web/userconfig_controller.cpp

aleos89 Apr 20, 2021

```suggestion ```

Outdated

src/web/userconfig_controller.cpp

aleos89 Apr 20, 2021

```suggestion #include "auth.hpp" #include "http.hpp" #include "sqllock.hpp" #include "web.hpp" ```

Outdated

src/web/userconfig_controller.cpp

aleos89 Apr 20, 2021

```suggestion ShowError("[GuildID: %d / World: \"%s\"] Not found in table\n", guild_id, world_name); ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion ShowDebug("Emblem is too big, current size is %d and the max length is %d.\n", length, MAX_EMBLEM_SIZE); ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion ShowError("Invalid image type %s, rejecting!\n", imgtype); ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion bool fail = false; if (!req.has_file("GDID")) { ShowDebug("Missing GuildID field for emblem download.\n"); fail = true; } if (!req.has_file("WorldName")) { ShowDebug("Missing WorldName field for emblem download.\n"); fail = true; } if (!req.has_file("Img")) { ShowDebug("Missing Img field for emblem download.\n"); fail = true; } if (!req.has_file("ImgType")) { ShowDebug("Missing ImgType for emblem download.\n"); fail = true; } if (fail) { ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion bool fail = false; if (!req.has_file("GDID")) { ShowDebug("Missing GuildID field for emblem download.\n"); fail = true; } if (!req.has_file("WorldName")) { ShowDebug("Missing WorldName field for emblem download.\n"); fail = true; } if (fail) { ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion content_type = "image/gif"; else { ShowError("Invalid image type %s, rejecting!\n", filetype); res.status = 404; res.set_content("Error", "text/plain"); return; } ```

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion ShowDebug("Emblem is too big, current size is %d and the max length is %d.\n", emblem_size, MAX_EMBLEM_SIZE); ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion #include <fstream> #include <iostream> #include <ostream> #include "../common/showmsg.hpp" #include "auth.hpp" #include "http.hpp" #include "sqllock.hpp" #include "web.hpp" ```

Outdated

src/web/emblem_controller.cpp

aleos89 Apr 20, 2021

```suggestion #include "http.hpp" #include "sqllock.hpp" #include "web.hpp" ```

Outdated

src/web/auth.cpp

aleos89 Apr 20, 2021

```suggestion @$(MAKE) -C ../../3rdparty/httplib ``` Missing end of file space.

src/web/Makefile.in

aleos89 Apr 20, 2021

```suggestion ```

Outdated

conf/inter_athena.conf

Lemongrass3110 Mar 10, 2021

Missing empty newline

Outdated

src/web/web-server.vcxproj

Lemongrass3110 Mar 10, 2021

Missing empty newline

Outdated

src/web/web-server.vcxproj.filters

Lemongrass3110 Mar 10, 2021

Could you mention why this was needed? Right now we only knew this was necessary for MSC and BORLAND.

src/common/cbasetypes.hpp

Lemongrass3110 Mar 10, 2021

Invert from enable to disable please. Should be on by default.

Outdated

configure.ac

Lemongrass3110 Mar 10, 2021

Please invert this to "--disable"

Outdated

configure

Lemongrass3110 Mar 10, 2021

Maybe put a small comment here that the web server also uses the character server's guild table? And also the login server's login table (token)? Otherwise redefine them here with a new name, but then again putting it into inter is useless in general.

conf/inter_athena.conf

Lemongrass3110 Mar 10, 2021

I wont bother looking at this part of the code, but please add any required pragmas required for surpressing any warnings that might come up and get reported. I hate when this comes from the users for third party libs.

3rdparty/httplib/httplib.cc

Lemongrass3110 Mar 10, 2021

Missing empty newline

Outdated

3rdparty/httplib/CMakeLists.txt

Lemongrass3110 Mar 10, 2021

Can be removed again now?

Outdated

.gitignore

Lemongrass3110 Mar 10, 2021

Should be on by default if we already add this to rAthena now.

Outdated

CMakeLists.txt

Lemongrass3110 Mar 10, 2021

Missing empty newline

Outdated

3rdparty/httplib/httplib.vcxproj

aleos89 Feb 8, 2021

Maybe a quick doc in the SQL Readme?

sql-files/web.sql

aleos89 Feb 8, 2021

These should be reverted.

Outdated

rAthena.sln

aleos89 Feb 8, 2021

```suggestion default). Enable it if you want to use the web ```

Outdated

configure

aleos89 Feb 8, 2021

Should be `.hpp`.

Outdated

configure

aleos89 Feb 8, 2021

Missing end of file break.

Outdated

conf/web_athena.conf

Resolved conversations (3)

Lemongrass3110 Mar 10, 2021

```suggestion import: conf/import/web_conf.txt ```

conf/web_athena.conf

Lemongrass3110 Mar 10, 2021

Alphabetical order?

.gitignore

Lemongrass3110 Mar 10, 2021

Does autoconf really need all those directories? Cant it just be the full directory instead of all those separate ones?

.gitignore