Enable *plagiarism script commands #6304
Open
+140
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lemongrass3110
added
component:core
hacktoberfest-accepted
aleos89
reviewed
Nov 10, 2021
Just a few more things I could see since I no longer have to review on a mobile device!
|
updated and rebased. |
|
So I'm good with this, but maybe the script name could use some loving? Something like |
- enable player to copy or erase skill
I would prefer the previous name since its easier to read, anyway updated it to |
|
You can also set the alias if you'd like, so that we have both names available! I see no harm in that as long as both are documented in the script_commands. 👍🏼 |
|
is okay, keep one is enough, wont take long to get used to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
unable to control the plagiarism skill using npc
both
enable to use script command to control skill plagiarism if needed.
enable player to copy or erase skill using NPC