Fixes Elemental Converter behavior #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #6627. * Elemental Converters will now be removed on weapon unequip/swap. * Adds RemoveOnUnequip, RemoveOnUnequipWeapon, and RemoveOnUnequipArmor status flags and dehardcoded statuses to utilize these flags. Thanks to @Everade, @Daraen1, and @Toshiro90!
|
I haven't updated my rathena yet, I can't help you with the result of this commit, so I'll trust others ;) @aleos89 |
|
You can always make a new clone and test from there! |
Lemongrass3110
approved these changes
Mar 29, 2022
Maybe dehardcode SC_HOVERING into the unequip script of
- Id: 2801
AegisName: Hovering_Booster
This would also allow to remove the hardcoded item id ITEMID_HOVERING_BOOSTER.
* Hovering Booster's cancellation of SC_HOVERING now takes place in the UnEquipScript, releasing the hard coded check. Thanks to @Lemongrass3110!
* Take into account item ID after removal of Hovering Booster.
|
Just wanted to note, BS Sacramenti (Benedictio status) is commented out in the status database, as it was in source, for removal on armor unequip. I just confirmed on a renewal Aegis that the status is indeed not removed on armor unequip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Addressed Issue(s): Fixes #6627
Server Mode: Pre-renewal and Renewal
Description of Pull Request:
Thanks to @Everade, @Daraen1, and @Toshiro90!