Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Command Updates: #85

Closed
wants to merge 2 commits into from
Closed

Conversation

cydh
Copy link
Contributor

@cydh cydh commented Jul 20, 2014

  • Added script commands to support spesified search for Bound & Rental Item that current 'countitem' & 'delitem' don't care about bound item nor rental item
    -- * countitem3, cartcountitem3, storagecountitem3: Works like countitem, but with flag
    -- * countitem4, cartcountitem4, storagecountitem4: Works like countitem2, but with flag
    -- * delitem3, cartdelitem3, storagedelitem3: Works like delitem, but with flag
    -- * delitem4, cartdelitem4, storagedelitem4: Works like delitem2, but with flag

Signed-off-by: Cydh Ramdh house.bad@gmail.com

- Added script commands to support spesified search for Bound & Rental Item that current 'countitem' & 'delitem' don't care about bound item nor rental item
-- * countitem3, cartcountitem3, storagecountitem3: Works like countitem, but with flag
-- * countitem4, cartcountitem4, storagecountitem4: Works like countitem2, but with flag
-- * delitem3, cartdelitem3, storagedelitem3: Works like delitem, but with flag
-- * delitem4, cartdelitem4, storagedelitem4: Works like delitem2, but with flag

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
@nanakiwurtz
Copy link
Contributor

@nanakiwurtz nanakiwurtz commented Jul 20, 2014

Can you leave some description/hints about these 'flags' ?

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
8 - Count Guild bound item (1<<(Bound_Guild+1))
16 - Count Party bound item (1<<(Bound_Party+1))
32 - Count Char bound item (1<<(Bound_Char+1))

Copy link
Contributor Author

@cydh cydh Jul 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@euphyy
Copy link
Contributor

@euphyy euphyy commented Jul 20, 2014

Why don't you just add the flag as an optional param in the *item and *item2 commands? They can't possibly overlap with the optional AID param, so if you're only given 1 optional param, you just have to check if it's less than or greater than START_ACCOUNT_NUM (or the max flag). It's way too messy to add so many new commands.

@cydh cydh closed this Jul 20, 2014
@cydh
Copy link
Contributor Author

@cydh cydh commented Nov 6, 2014

suggestion by @euphyy gives more sense, and I think I can change the flag to be

0 - Ignore the criteria, works like 'countitem'/'delitem' itself
1 - Count/delete ALL non-bound & non-rental item (1<<(Bound_None))
2 - Count/delete Account bound item (1<<(Bound_Account))
4 - Count/delete Guild bound item (1<<(Bound_Guild))
8 - Count/delete Party bound item (1<<(Bound_Party))
16 - Count/delete Char bound item (1<<(Bound_Char))
32 - Count/delete Rental item
_64 - Count/delete _stackable* item with guid (sample usage is for merging the separated stackable item become 1 slot)*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants