New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with IE (all versions) #25

Closed
rodanato opened this Issue May 19, 2016 · 12 comments

Comments

Projects
None yet
4 participants
@rodanato

rodanato commented May 19, 2016

Examples doesnt work in IE (all versions), neither my demo,
http://vuetable.ratiw.net/examples/bootstrap.html

This is the error:
[Vue warn]: Unknown custom element: - did you register the component correctly? For recursive components, make sure to provide the "name" option.

I put the name to de components but still the same.

@ratiw

This comment has been minimized.

Owner

ratiw commented May 20, 2016

@rodanato I just update the examples and test them on MS Edge browser and seem to work now. However, I'm not sure about IE because I don't use them. I think it might be its own the javascript engine problem. But after you've tried again and still see the error, please let me know. I just can't promise that I'll be able to fix it.

@rodanato

This comment has been minimized.

rodanato commented May 20, 2016

Thanks for answer. What exactly you have changed?

@ratiw

This comment has been minimized.

Owner

ratiw commented May 21, 2016

@rodanato I only updated the code on the demo site to be the same as in the examples section of this repo. Yesterday, I did try to test those examples on IE 11 and it seems Vue itself is not happy with IE11 due to its internal Javascript engine. So, I suggest you use Chrome or something else other than IE if possible. Because I will not be able to fix those errors if it is from Vue itself. :|

@mozami

This comment has been minimized.

Collaborator

mozami commented May 22, 2016

Hi @ratiw Ive just tested this on IE11 (that is the only version i have access to) and ran into similar errors as @rodanato has described above.

I may be wrong, but I suspect that this is likely due to the way the pagination component being nested within the vuetables component - to me, that is what may be causing the problem. I will test this out tomorrow again and post more details.

@mozami

This comment has been minimized.

Collaborator

mozami commented May 23, 2016

Ive played around with this a bit more, and the problem came from the <template> tags within Vuetable.vue file. Removing the templates makes things run without any exceptions (but obviously does not render the table).

After digging around a bit more, it seems that IE does not respond well to having <template> tags within a <table> element, while other browsers are be a bit more forgiving .

You can see more on this + some workarounds here and here.

@ratiw

This comment has been minimized.

Owner

ratiw commented May 23, 2016

Thanks a lot, @mozami.

@rodanato In this case, I don't think I can do anything with it because it would be impossible for me not to use <template> tags inside <table>.

@ratiw ratiw closed this May 23, 2016

@mozami

This comment has been minimized.

Collaborator

mozami commented May 23, 2016

Hi @ratiw, thanks for the update.

I understand and respect your decision to keep things as they are. However, perhaps you should mention browser compatibility in the readme - so users are aware of this.

Also, out of curiosity, does vuetable work in edge? (I dont have access to edge to test with).

@ratiw

This comment has been minimized.

Owner

ratiw commented May 23, 2016

@mozami Yeah, I'll do that tonight.

And for MS Edge, it seems to be working fine, but I can't really tell as it is not the main one I use. As far as I've run the same examples on it, it does not have any issue that I see.

@rodanato

This comment has been minimized.

rodanato commented May 23, 2016

Hi, I read about using < script type="x/templates" > instead of < template > tag to use components in IE, if you see the vuejs examples of components, they use this and it works on IE.
However I'm not sure yet how to use it, but it seems to be the way.

@ratiw

This comment has been minimized.

Owner

ratiw commented May 24, 2016

@rodanato I don't think It's the same. The problem here is using tag inside tag, which IE11 cannot handle that and I have no way to make vuetable work the way it is without using that

.

@bh-lay

This comment has been minimized.

bh-lay commented Oct 12, 2016

so,this problem has always existed?

@ratiw

This comment has been minimized.

Owner

ratiw commented Oct 12, 2016

@bh-lay Yes. And I just found out that 2 sections in the README.md (Browser Compatibility and Contributions) was unintentionally deleted awhile back ago when I reverted the commit.

Sorry for that. But this is no longer an issue in vuetable-2, which uses Vue 2.0, thanks to the virtual DOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment