Enables multisorting #36
Merged
Conversation
New property `multiSort` added. If it's false (default), everything works like before However when it's set to true, you can sort data by several selected columns. The most recent selected column has the smallest precedence. The generated request looks like this: `?sort=id|desc,name|asc,email|asc` Of course to get this working, you'll need a backend which is able to parse the above format. Please note that this commit breaks backwards compatibility *a bit*. Now if you want to initialise the sort-order property, it should be done with an array like this. Just wrap your previous object in an array. ``` [{ field: 'name', direction: 'asc' }] ```
@balping Nice! Just got a chance to look at your PR. The breaking change is ok to me and it is necessary. But I think it would be better if you could make the multisort to react to modifier key (like holding the
and in the method declaration
What do you think? Would love to hear your opinion on this. :) |
Yes, I agree with you, it's probably more user friendly this way, so I added this functionality. In addition I made another commit that marks fields with stronger precedence with darker color, like so: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New property
multiSort
added. If it's false (default), everything works like beforeHowever when it's set to true, you can sort data by several selected columns. The most recent selected column has the smallest precedence.
The generated request looks like this:
?sort=id|desc,name|asc,email|asc
Of course to get this working, you'll need a backend which is able to parse the above format.
Please note that this commit breaks backwards compatibility a bit. Now if you want to initialise the sort-order property, it should be done with an array like this. Just wrap your previous object in an array.