Browse files

gitweb: remove unnecessary test when closing file descriptor

It happens that closing file descriptor fails whereas the blob is
perfectly readable.  According to perlman the reasons could be:

   If the file handle came from a piped open, "close" will additionally
   return false if one of the other system calls involved fails, or if the
   program exits with non-zero status.  (If the only problem was that the
   program exited non-zero, $! will be set to 0.)  Closing a pipe also waits
   for the process executing on the pipe to complete, in case you want to
   look at the output of the pipe afterwards, and implicitly puts the exit
   status value of that command into $?.

   Prematurely closing the read end of a pipe (i.e. before the process writ-
   ing to it at the other end has closed it) will result in a SIGPIPE being
   delivered to the writer.  If the other end can't handle that, be sure to
   read all the data before closing the pipe.

In this case we don't mind that close fails.

Signed-off-by: Sylvain Rabot <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
sylr authored and gitster committed Dec 30, 2010
1 parent 3ce19eb commit 3ca7353cab4ed6c7efac0c8d7477c87112fc7350
Showing with 1 addition and 2 deletions.
  1. +1 −2 gitweb/gitweb.perl
@@ -3465,8 +3465,7 @@ sub run_highlighter {
my ($fd, $highlight, $syntax) = @_;
return $fd unless ($highlight && defined $syntax);
close $fd
or die_error(404, "Reading blob failed");
close $fd;
open $fd, quote_command(git_cmd(), "cat-file", "blob", $hash)." | ".
" --xhtml --fragment --syntax $syntax |"

0 comments on commit 3ca7353

Please sign in to comment.