Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ratpack-base gradle plugin #419

Closed
erdi opened this issue Aug 12, 2014 · 4 comments
Closed

Add ratpack-base gradle plugin #419

erdi opened this issue Aug 12, 2014 · 4 comments
Assignees

Comments

@erdi
Copy link
Member

erdi commented Aug 12, 2014

To allow using dependency definition helper (ratpack.dependency()) in a consistent way from projects that are not ratpack applications themselves.

@johnrengelman
Copy link
Member

Doing this would require the ratpack/ratpack-version.txt file to present as the RatpackDependencies class loads it to get the version to apply.
Is there a desire to provide an alternative method to this for non-Ratpack applications? Perhaps a project property or something?

@erdi
Copy link
Member Author

erdi commented Oct 2, 2014

Yes, that file is on the classpath of the plugin so as a plugin user you wouldn't need to do anything.

You can always use maven coordinates of these dependencies if you're not using the plugin. This issue is about having a way of using the nice "specify version in one place" convenience mechanism if you don't want to apply ratpack-java plugin to your project.

@johnrengelman
Copy link
Member

Oh right, yeah, looked at that wrong. Thanks. — John

On Thu, Oct 2, 2014 at 4:00 PM, Marcin Erdmann notifications@github.com
wrote:

Yes, that file is on the classpath of the plugin so as a plugin user you wouldn't need to do anything.

Reply to this email directly or view it on GitHub:
#419 (comment)

@johnrengelman
Copy link
Member

Created PR - #462

@erdi erdi added this to the release-0.9.10 milestone Oct 3, 2014
@erdi erdi self-assigned this Oct 3, 2014
@erdi erdi closed this as completed Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants