New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render health checks as JSON for ratpack-codahale-metrics #467
Conversation
@rhart do you mind shepharding this one as you're our metrics expert? |
No prob, will take a look tomorrow |
since I'm being shepherded, Baaaaaa.... |
Never say "Baaaa" to a Welshman ;) |
@wmacgyver now we're returning json we should prob be using Also, I think we should use |
sure, I'll make the changes you suggested tomorrow. |
content.getReponse().send to avoid lookup as per requested
enough yet to be making this change
I'll merge this when I get back from hols. It'll be after 0.9.10 I'm thinking it might be worthwhile explicitly setting "no cache" response headers too. As I understand it you can't guarantee the browser won't cache the response without setting them. Unless you're explicit you're at the mercy of the browser. |
added http header to disable caching. I did all 3 variant to make sure it cover all the browsers. Hope that wasn't too over zealous. |
Render health checks as JSON for ratpack-codahale-metrics
Sorry it's taken so long but y'know, hols take priority :) |
@rhart no worries, thanks for the hand holding |
per #416
I kept it simple and just use the Jackson mapper