Deploying to heroku does not work #221

Closed
dgollahon opened this Issue Jul 25, 2016 · 8 comments

Comments

Projects
None yet
7 participants
@dgollahon

dgollahon commented Jul 25, 2016

First of all, thanks for building this--I've found it useful. Unfortunately it seems like directly deploying to heroku does not work correctly.

It appears to be due to this line, which expects dist/ to exist, but does not by default, since it is ignored from source control.

I was able to work around it, but it was pretty confusing when I first tried to setup the server. It would be great if you could fix this or, at least, provide a better warning when unable to access dist/.

Thanks!

@tonyedwardspz

This comment has been minimized.

Show comment
Hide comment
@tonyedwardspz

tonyedwardspz Jul 25, 2016

@dgollahon I'm having the same issue. How did you work around it? Build locally and then deploy to heroku?

tonyedwardspz commented Jul 25, 2016

@dgollahon I'm having the same issue. How did you work around it? Build locally and then deploy to heroku?

@dgollahon

This comment has been minimized.

Show comment
Hide comment
@dgollahon

dgollahon Jul 25, 2016

@tonyedwardspz: yeah, just checked dist/ into my copy of the repo and pushed that.

@tonyedwardspz: yeah, just checked dist/ into my copy of the repo and pushed that.

@niftylettuce

This comment has been minimized.

Show comment
Hide comment

You can use this if you need to in the meanwhile:

https://heroku.com/deploy?template=https://github.com/niftylettuce/slackin/tree/master

@zenspider

This comment has been minimized.

Show comment
Hide comment
@zenspider

zenspider Aug 10, 2016

Confirmed that @niftylettuce's branch works fine. This bug has caused a LOT of teeth gnashing. Thank you @niftylettuce for the help!

Confirmed that @niftylettuce's branch works fine. This bug has caused a LOT of teeth gnashing. Thank you @niftylettuce for the help!

@duaneking

This comment has been minimized.

Show comment
Hide comment
@duaneking

duaneking Aug 13, 2016

When will this be fixed in the official branch?

duaneking commented Aug 13, 2016

When will this be fixed in the official branch?

@productcampsg

This comment has been minimized.

Show comment
Hide comment
@productcampsg

productcampsg Aug 16, 2016

Thank you @niftylettuce! I had the Application Error page whenever I tried deploying to Heroku using the official branch.

I'm getting a 404 on http://slack.productcampsg.com/ but http://productcampsg.herokuapp.com shows the app.

Something like http://slack.mindtheproduct.com/ works. Does the Landing Page work for all of you 👀?

productcampsg commented Aug 16, 2016

Thank you @niftylettuce! I had the Application Error page whenever I tried deploying to Heroku using the official branch.

I'm getting a 404 on http://slack.productcampsg.com/ but http://productcampsg.herokuapp.com shows the app.

Something like http://slack.mindtheproduct.com/ works. Does the Landing Page work for all of you 👀?

@niftylettuce

This comment has been minimized.

Show comment
Hide comment
@niftylettuce

niftylettuce Sep 16, 2016

@productcampsg it works for me - maybe your Heroku dyno needs to be upgraded to Hobby or have a server ping it occasionally to wake up

@productcampsg it works for me - maybe your Heroku dyno needs to be upgraded to Hobby or have a server ping it occasionally to wake up

@aaalveee

This comment has been minimized.

Show comment
Hide comment
@aaalveee

aaalveee Dec 7, 2016

@niftylettuce's branch is crashing for me, shows "Application Error"

aaalveee commented Dec 7, 2016

@niftylettuce's branch is crashing for me, shows "Application Error"

@rauchg rauchg closed this in 77c9d94 Feb 9, 2017

mexisme added a commit to devopsnz/slackin that referenced this issue Mar 10, 2017

mexisme added a commit to devopsnz/slackin that referenced this issue Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment