/slackin

Show better error when slack subdomain incorrect #261

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jamo @rauchg
@jamo
Contributor

jamo commented Jan 5, 2017

e.g when SLACK_SUBDOMAIN="<zeit-community>" following error would show up:

/home/nowuser/src/dist/slack.js:53
        (res.body.channels || []).forEach(function (channel) {
            ^
TypeError: Cannot read property 'body' of undefined

When really err is populated and contains real error.
@jamo jamo Show better error when slack subdomain isn't correctly set 
e.g when `SLACK_SUBDOMAIN="<zeit-community>"` following error would show up:
```
/home/nowuser/src/dist/slack.js:53
        (res.body.channels || []).forEach(function (channel) {
            ^
TypeError: Cannot read property 'body' of undefined
```

When really err is populated and contains real error.
 73a99cb

rauchg merged commit e9749ef into rauchg:master Jan 5, 2017

jamo deleted the jamo:fix/auth-error-exception branch Jan 5, 2017

@mexisme mexisme added a commit to devopsnz/slackin that referenced this pull request Mar 10, 2017

@jamo @mexisme jamo + mexisme Show better error when slack subdomain isn't correctly set (#261) 
e.g when `SLACK_SUBDOMAIN="<zeit-community>"` following error would show up:
```
/home/nowuser/src/dist/slack.js:53
        (res.body.channels || []).forEach(function (channel) {
            ^
TypeError: Cannot read property 'body' of undefined
```

When really err is populated and contains real error.
 797120a

@mexisme mexisme added a commit to devopsnz/slackin that referenced this pull request Mar 10, 2017

@jamo @mexisme jamo + mexisme Show better error when slack subdomain isn't correctly set (#261) 
e.g when `SLACK_SUBDOMAIN="<zeit-community>"` following error would show up:
```
/home/nowuser/src/dist/slack.js:53
        (res.body.channels || []).forEach(function (channel) {
            ^
TypeError: Cannot read property 'body' of undefined
```

When really err is populated and contains real error.
 52b896a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment