Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signup via badges #353

Merged
merged 1 commit into from Dec 19, 2017
Merged

Fix signup via badges #353

merged 1 commit into from Dec 19, 2017

Conversation

@chromy
Copy link
Contributor

chromy commented Nov 23, 2017

Signups via the badge go down a slightly different path than signups via the main page (eventually ending up at https://example.com/iframe/dialog, https://github.com/rauchg/slackin/blob/master/lib/index.js#L248). Unfortunately this path doesn't pass gcaptcha_sitekey to splash (https://github.com/rauchg/slackin/blob/master/lib/splash.js#L3) which results in this error when you try to sign up:

Uncaught TypeError: Cannot read property 'value' of undefined
    at HTMLBodyElement.<anonymous> (client.js:23)

The fix is to pass gcaptcha_sitekey which I have tested locally.

@chromy chromy changed the title Fix gcaptcha in badges/iframe mode Fix signup via badges Nov 23, 2017
@chromy chromy force-pushed the chromy:master branch from c12cc05 to c51dda4 Nov 23, 2017
@rauchg rauchg merged commit 7962ff0 into rauchg:master Dec 19, 2017
MichaelDaum added a commit to MichaelDaum/slackin that referenced this pull request May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.