New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment to IBM Cloud #384

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@hickeyma
Copy link
Collaborator

hickeyma commented Oct 3, 2018

This fix updates the deployment to use a toolchain where the parameters can be configured by the user as required by slackin server during deployment.

This closes #375 and closes #186.

Fix deployment to IBM Cloud
This fix updates the deployment to use a toolchain where the parameters can be configured by the user as required by slackin server during deployment.

This closes #375 and closes #186.
@hickeyma

This comment has been minimized.

Copy link
Collaborator

hickeyma commented Oct 3, 2018

@rauchg Ready for review. Pls. note that when testing you will need to change the repository in the deployment link as follows: https://github.com/hickeyma/slackin&branch=fix-ibm-cloud-deployment. The deployment link will be shown when you click to deploy on "IBM Cloud".

The URL would then become something like this: https://console.bluemix.net/devops/setup/deploy?repository=https://github.com/hickeyma/slackin&branch=fix-ibm-cloud-deployment.

This workaround is needed because the deployment files are in my clone and branch and not yet merged into the slackin repo and master branch.

@henrynash

This comment has been minimized.

Copy link

henrynash commented Dec 5, 2018

+1 LGTM - Nice job.

@hickeyma hickeyma self-assigned this Dec 5, 2018

@hickeyma

This comment has been minimized.

Copy link
Collaborator

hickeyma commented Dec 5, 2018

Have received 2 +1's from @henrynash and through email from @rauchg ("Added you to the repo. I trust that you'll put it into great shape. Thank you").

@evilrabbit do you have any comments?

@hickeyma hickeyma merged commit fa88a86 into rauchg:master Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment