Optional checkbox for code of conduct agreement #69
+66
−8
Conversation
limulus
added
some commits
Jun 21, 2015
ndarville
commented
Jul 1, 2015
|
|
kizu
commented
Jul 16, 2015
|
|
cheeaun
commented
Jul 16, 2015
|
|
|
This is awesome! Thanks a lot. I have some concerns about the look n feel, will try to adjust it soon. |
megahbite
commented
Sep 10, 2015
|
For consistency's sake, would it not be better to handle the validation of the state of the checkbox in the same place as the email is validated: in the |
|
@megahbite agreed. If we were going to have one and not the other, I would have the |
rauchg
closed this
in bbc8e8d
Nov 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
limulus commentedJul 1, 2015
Thanks for making and maintaining this project! In this PR I’ve implemented an option for a checkbox that ensures the user agrees to a linked code of conduct before requesting an invite. You can see it in action on the TucsonJS slackin. I suspect many other users of slackin may find this feature helpful.
Some notes on the implementation: Adding the option for the checkbox was relatively straightforward in the main interface, however it did add some complications with the badge dialog interface. The fact that the checkbox is optional causes the dialog to be of variable height, so I made the dialog adjust itself to the height of its content before showing itself (using the same methodology the badge uses to adjust its width).
Thanks for considering! Let me know if there is something I should have done differently.