Optional checkbox for code of conduct agreement #69

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
6 participants
Contributor

limulus commented Jul 1, 2015

Thanks for making and maintaining this project! In this PR I’ve implemented an option for a checkbox that ensures the user agrees to a linked code of conduct before requesting an invite. You can see it in action on the TucsonJS slackin. I suspect many other users of slackin may find this feature helpful.

Some notes on the implementation: Adding the option for the checkbox was relatively straightforward in the main interface, however it did add some complications with the badge dialog interface. The fact that the checkbox is optional causes the dialog to be of variable height, so I made the dialog adjust itself to the height of its content before showing itself (using the same methodology the badge uses to adjust its width).

Thanks for considering! Let me know if there is something I should have done differently.

👍

kizu commented Jul 16, 2015

👍

cheeaun commented Jul 16, 2015

👍

Owner

rauchg commented Jul 24, 2015

This is awesome! Thanks a lot. I have some concerns about the look n feel, will try to adjust it soon.

megahbite referenced this pull request Sep 10, 2015

Closed

Code of conduct check #98

For consistency's sake, would it not be better to handle the validation of the state of the checkbox in the same place as the email is validated: in the /invite handler in index.js?

Owner

rauchg commented Nov 19, 2015

@megahbite agreed. If we were going to have one and not the other, I would have the /invite handler exclusively. Both sound good, provided that the client-side one provides the user feedback about the error.

rauchg closed this in bbc8e8d Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment