New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter: Template Literal Revision #8

Open
rauschma opened this Issue Feb 13, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@rauschma
Owner

rauschma commented Feb 13, 2018

No description provided.

@vsemozhetbyt

This comment has been minimized.

vsemozhetbyt commented Mar 11, 2018

Maybe

function tagFunc(tmplObj, substs) {
->
function tagFunc(tmplObj, ...substs) {

to stress that substs is not an array like tmplObj

@vsemozhetbyt

This comment has been minimized.

vsemozhetbyt commented Mar 11, 2018

"The solution is drop..." -> "The solution is to drop..." ?

@vsemozhetbyt

This comment has been minimized.

vsemozhetbyt commented Mar 11, 2018

Not sure if this is an issue.

All other chapters mention GitHub proposal repositories except this one. Maybe https://github.com/tc39/proposal-template-literal-revision is also worth mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment