New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed keyword input to list filter #1

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@emroch
Contributor

emroch commented Aug 29, 2018

By using a list filter, the three subcommands will be shown as list items after typing wifi. With just a keyword, the user has to enter the subcommand explicitly to continue, but with this modification you have the option to use the arrow keys to type "wi " for "off" (similarly for on and restart). Typing the whole command works just as before.

@ravelll

This comment has been minimized.

Owner

ravelll commented Sep 2, 2018

Thank you for contributing, it looks almost good !
I think it'll be good if it has no "WiFi" duplication (like below) when we complement the command. 😃
image
Can you fix it to be "wifi On" ?

@emroch

This comment has been minimized.

Contributor

emroch commented Sep 4, 2018

I took "WiFi" out of the list filter item titles. This has the desired effect of displaying "wifi on" when tab completing, but means that the list item only shows "on" in the Alfred dropdown. The subtitle and icon are probably enough to indicate the functionality though.

@ravelll

This comment has been minimized.

Owner

ravelll commented Sep 5, 2018

The subtitle and icon are probably enough to indicate the functionality though.

I think so. 👍
Thank you !

@ravelll ravelll merged commit 4020f14 into ravelll:master Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment