Permalink
Browse files

RavenDB-6046 Query page doesn't show results when table is not visible

  • Loading branch information...
1 parent d92eb23 commit e694ac7c8b55b241428cecd3d077f16476f7c9cc @ml054 ml054 committed with ayende Jan 9, 2017
@@ -102,11 +102,8 @@ class dynamicHeightBindingHandler {
var windowHeight: number = ko.utils.domData.get(element, windowHeightKey);
desiredElementHeight = windowHeight - elementTop - padding;
}
- var minimumHeight = 100;
- if (desiredElementHeight >= minimumHeight) {
- $element.innerHeight(desiredElementHeight);
- $element.trigger("DynamicHeightSet", desiredElementHeight);
- }
+ $element.innerHeight(desiredElementHeight);
+ $element.trigger("DynamicHeightSet", desiredElementHeight);
}
}
}
@@ -307,7 +307,7 @@
<div class="suggestion-box" data-bind="visible: $root.showSuggestions, foreach: $root.indexSuggestions">
<div>Did you mean <a data-bind="text: Suggestion, click: $root.applySuggestion.bind($root, $data)" href="#"></a> for the field <i data-bind="text: FieldName"></i>?</div>
</div>
- <div id="queryResultsGrid" data-bind="widget: { kind: 'virtualTable', customColumns: currentColumnsParams, itemsSource: queryResults, selectedIndices: selectedResultIndices, gridSelector: '#queryResultsGrid', useContextMenu: true, showIds: true, showCheckboxes: true, maxHeight: '450px', isIndexMapReduce: isIndexMapReduce, collections: collections, contextMenuOptions: ['CopyItems', 'CopyIDs' , 'Delete', 'EditItem' ], noResultsMessage: 'No results were found. For NotAnalyzed fields you may wish to search with [[term]].'}"></div>
+ <div id="queryResultsGrid" data-bind="widget: { kind: 'virtualTable', customColumns: currentColumnsParams, itemsSource: queryResults, selectedIndices: selectedResultIndices, gridSelector: '#queryResultsGrid', useContextMenu: true, showIds: true, showCheckboxes: true, maxHeight: '450px', minHeight: '200px', isIndexMapReduce: isIndexMapReduce, collections: collections, contextMenuOptions: ['CopyItems', 'CopyIDs' , 'Delete', 'EditItem' ], noResultsMessage: 'No results were found. For NotAnalyzed fields you may wish to search with [[term]].'}"></div>
</div>
</div>
</div>
@@ -24,7 +24,7 @@
</div>
</div>
- <div class="ko-grid-viewport-container" data-bind="dynamicHeight: { resizeTrigger: window.ravenStudioWindowHeight(), target: settings.dynamicHeightTargetSelector, bottomMargin: bottomMargin, container: settings.container }, style: { 'max-height': settings.maxHeight }">
+ <div class="ko-grid-viewport-container" data-bind="dynamicHeight: { resizeTrigger: window.ravenStudioWindowHeight(), target: settings.dynamicHeightTargetSelector, bottomMargin: bottomMargin, container: settings.container }, style: { 'max-height': settings.maxHeight, 'min-height': settings.minHeight }">
<div class="ko-grid-viewport" data-bind="foreach: recycleRows, style: { height: virtualHeight() + 'px', width: virtualWidth() + 'px' }">
<div class="ko-grid-row" data-bind="foreach: $parent.columns, visible: isInUse, style: { height: $parent.rowHeight + 'px', top: top() + 'px', width: $parent.virtualWidth() + 'px' }, css: { even: rowIndex() % 2 === 0, checked: isChecked}">
<div class="ko-grid-cell" data-bind="template: { name: $parent.getOrAddTemplateNameCache(binding)() }, style: { width: width() + 'px' }, attr: { title: ($parent.getCellTemplate(binding) !== 'customTemplate') ? $parent.getCellData(binding) : '' }">
@@ -63,6 +63,7 @@ class ctor {
useContextMenu: boolean;
container?: string;
maxHeight: string;
+ minHeight: string;
customColumnParams: { [column: string]: customColumnParams };
isIndexMapReduce: KnockoutObservable<boolean>;
isCopyAllowed: boolean;
@@ -88,6 +89,7 @@ class ctor {
showIds: true,
useContextMenu: true,
maxHeight: 'none',
+ minHeight: 0,
customColumnParams: {},
isIndexMapReduce: ko.observable<boolean>(true),
isCopyAllowed: true,

0 comments on commit e694ac7

Please sign in to comment.