Repository navigation
IAsyncDocumentSession..Advanced.ExistsAsync() returns false if IDocumentStore.OnBeforeDelete throws an exception #12398
Description
Activity
Any exception that is thrown by the session would effectively invalidate it, note.
What actually happens here is that we first record that we intend to remove the document, even though the exception "failed" the operation. At this point, you cannot assume anything about the state of the session.To do otherwise would cause us to have to be very careful and would still leave you with complicated scenarios in the case of server side failure.
ExistsAsyncchecks first that the document was registered for removal, and it wasn't removed when the exception happened.
Steps to reproduce:
IDocumentStore.OnBeforeDelete, e.g.store.OnBeforeDelete += (_, _) => throw new Exception();DbSession.Delete("Tickets/1-A")OnBeforeDeleteawait DbSession.Advanced.ExistsAsync("Tickets/1-A")would returnfalse.DbSession.Advanced.Clear()first thenExistsAsyncwould returntrue.See a relevant test in the YABT project.