Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnClose event #10

Closed
egorzot opened this issue Oct 15, 2018 · 5 comments
Labels

Comments

@egorzot
Copy link

@egorzot egorzot commented Oct 15, 2018

Description

Maybe It would be better if we have an OnClose event to handle menu closing?

close () {
  this.top = null;
  this.left = null;
  this.data = null;
  this.show = false;
  this.$emit('close');
},
@rawilk rawilk added the enhancement label Oct 15, 2018
@rawilk

This comment has been minimized.

Copy link
Owner

@rawilk rawilk commented Oct 15, 2018

Good idea, I will implement this sometime when I get a chance to.

@egorzot

This comment has been minimized.

Copy link
Author

@egorzot egorzot commented Oct 15, 2018

@rawilk can I send PR ?

@rawilk rawilk referenced this issue Oct 15, 2018
@rawilk rawilk closed this in 6b6dc05 Oct 15, 2018
@rawilk

This comment has been minimized.

Copy link
Owner

@rawilk rawilk commented Oct 15, 2018

@egorzot - Thanks, but I already have the changes implemented since it was a small change. See PR #11.

@rawilk

This comment has been minimized.

Copy link
Owner

@rawilk rawilk commented Oct 15, 2018

I did also add in the ability to listen for an open event on the menu in version 3.3.0, as I'm sure you'll see in the PR I made.

@egorzot

This comment has been minimized.

Copy link
Author

@egorzot egorzot commented Oct 16, 2018

@rawilk thanks 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.