Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitting "close" events on scroll with menu closed #13

Closed
hansy opened this issue Oct 30, 2018 · 1 comment
Labels
bug

Comments

@hansy
Copy link

@hansy hansy commented Oct 30, 2018

v.3.3.1

I'm seeing a ton of "close" events being emitted on scroll, even when the context menu is closed. Is this normal behavior? Do I need to worry about the flurry of emitted events impacting performance or memory?

@rawilk rawilk closed this in aec2d2f Nov 19, 2018
@rawilk

This comment has been minimized.

Copy link
Owner

@rawilk rawilk commented Nov 19, 2018

@hansy - Sorry for the delayed response. You shouldn't have to worry about any performance impacts with that, however I have updated the package to only emit that event if the menu is actually open. See 3.4.0 for more details.

@rawilk rawilk added the bug label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.