Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@close does not fire when and item is selected #23

Closed
ChuckFields opened this issue May 30, 2019 · 3 comments

Comments

@ChuckFields
Copy link

@ChuckFields ChuckFields commented May 30, 2019

Description

@close does not fire when the context menu is closed via selecting an item with the mouse or with the keyboard.

Version

4.0.0

@rawilk

This comment has been minimized.

Copy link
Owner

@rawilk rawilk commented May 31, 2019

I will look into this

@rawilk

This comment has been minimized.

Copy link
Owner

@rawilk rawilk commented Jun 3, 2019

@ChuckFields

After looking at it, I forgot that I had a conditional in there when I first implemented this. Apparently it was emitting the close event twice for some reason when I first did that so I just elected to not emit it on click events.

After playing around with it, it seems that's not the case anymore and now I've dropped that conditional and updated the package. If you update to version 4.0.1 it should always emit the the close event now for you anytime the menu is closed.

@ChuckFields

This comment has been minimized.

Copy link
Author

@ChuckFields ChuckFields commented Jun 4, 2019

@rawilk Works perfectly, thank you. I'll close this issue.

@ChuckFields ChuckFields closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.