Skip to content
This repository was archived by the owner on Oct 5, 2022. It is now read-only.

Conversation

@rawilk
Copy link
Owner

@rawilk rawilk commented Oct 12, 2019

Description of the Change

As brought up in issue #33, the bundle size is increased by two functions from core-js. To reduce the bundle size of the menu, local polyfills have been created to remove the need to include core-js as a dependency.

Benefits

  • Smaller bundle size
  • Less dependencies

Possible Drawbacks

  • Polyfills created here may not always work (haven't been thoroughly tested in older browsers).

Applicable Issues

#33

@rawilk rawilk added the dependencies Pull requests that update a dependency file label Oct 12, 2019
@rawilk rawilk merged commit c530f3b into master Oct 12, 2019
@rawilk rawilk deleted the remove-core-js-dep branch October 12, 2019 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants