Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] Make Docker Build Python file easier to use! #14223

Merged
merged 4 commits into from Feb 26, 2021
Merged

[Docker] Make Docker Build Python file easier to use! #14223

merged 4 commits into from Feb 26, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Feb 20, 2021

Why are these changes needed?

  • This File uses a weird mix of environment variables to determine information that could easily be passed in. This PR removes some of that complexity. The other thing that this PR does is make it possible for humans to easily use this script!

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt requested a review from simon-mo February 20, 2021 01:18
@ijrsvt
Copy link
Contributor Author

ijrsvt commented Feb 20, 2021

cc @pdames Some cleanup of these files :)

@ijrsvt ijrsvt added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 24, 2021
@ijrsvt ijrsvt removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 26, 2021
@ijrsvt ijrsvt changed the title [Docker] Make Docker Build easier to use! [Docker] Make Docker Build Python file easier to use! Feb 26, 2021
@ijrsvt ijrsvt merged commit 8cfaea5 into ray-project:master Feb 26, 2021
@ijrsvt ijrsvt deleted the cleanup-docker-build branch February 26, 2021 23:23
@ijrsvt ijrsvt mentioned this pull request Mar 8, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijrsvt @simon-mo